* [U-Boot] [U-boot] [Patch] dma: keystone_nav: remove spurious qm_cfg verification
@ 2014-11-03 23:39 Ivan Khoronzhuk
2014-11-04 16:46 ` Tom Rini
2014-11-05 21:32 ` [U-Boot] [U-Boot, U-boot] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Ivan Khoronzhuk @ 2014-11-03 23:39 UTC (permalink / raw
To: u-boot
The verification qm_cfg existence is done at ksnav_init().
So, there is no need to verify it after initialization.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
---
drivers/dma/keystone_nav.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/dma/keystone_nav.c b/drivers/dma/keystone_nav.c
index 77707c2..dfca75a 100644
--- a/drivers/dma/keystone_nav.c
+++ b/drivers/dma/keystone_nav.c
@@ -81,9 +81,6 @@ void qm_close(void)
{
u32 j;
- if (qm_cfg == NULL)
- return;
-
queue_close(qm_cfg->qpool_num);
qm_cfg->mngr_cfg->link_ram_base0 = 0;
@@ -105,9 +102,6 @@ void qm_push(struct qm_host_desc *hd, u32 qnum)
{
u32 regd;
- if (!qm_cfg)
- return;
-
cpu_to_bus((u32 *)hd, sizeof(struct qm_host_desc)/4);
regd = (u32)hd | ((sizeof(struct qm_host_desc) >> 4) - 1);
writel(regd, &qm_cfg->queue[qnum].ptr_size_thresh);
@@ -127,9 +121,6 @@ struct qm_host_desc *qm_pop(u32 qnum)
{
u32 uhd;
- if (!qm_cfg)
- return NULL;
-
uhd = readl(&qm_cfg->queue[qnum].ptr_size_thresh) & ~0xf;
if (uhd)
cpu_to_bus((u32 *)uhd, sizeof(struct qm_host_desc)/4);
@@ -139,9 +130,6 @@ struct qm_host_desc *qm_pop(u32 qnum)
struct qm_host_desc *qm_pop_from_free_pool(void)
{
- if (!qm_cfg)
- return NULL;
-
return qm_pop(qm_cfg->qpool_num);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [U-boot] [Patch] dma: keystone_nav: remove spurious qm_cfg verification
2014-11-03 23:39 [U-Boot] [U-boot] [Patch] dma: keystone_nav: remove spurious qm_cfg verification Ivan Khoronzhuk
@ 2014-11-04 16:46 ` Tom Rini
2014-11-05 21:32 ` [U-Boot] [U-Boot, U-boot] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2014-11-04 16:46 UTC (permalink / raw
To: u-boot
On Tue, Nov 04, 2014 at 01:39:27AM +0200, Ivan Khoronzhuk wrote:
> The verification qm_cfg existence is done at ksnav_init().
> So, there is no need to verify it after initialization.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
Reviewed-by: Tom Rini <trini@ti.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141104/7db24400/attachment.pgp>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [U-Boot, U-boot] dma: keystone_nav: remove spurious qm_cfg verification
2014-11-03 23:39 [U-Boot] [U-boot] [Patch] dma: keystone_nav: remove spurious qm_cfg verification Ivan Khoronzhuk
2014-11-04 16:46 ` Tom Rini
@ 2014-11-05 21:32 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2014-11-05 21:32 UTC (permalink / raw
To: u-boot
On Tue, Nov 04, 2014 at 01:39:27AM +0200, Khoronzhuk, Ivan wrote:
> The verification qm_cfg existence is done at ksnav_init().
> So, there is no need to verify it after initialization.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> Reviewed-by: Tom Rini <trini@ti.com>
Applied to u-boot-ti/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141105/3201be0d/attachment.pgp>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-05 21:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-03 23:39 [U-Boot] [U-boot] [Patch] dma: keystone_nav: remove spurious qm_cfg verification Ivan Khoronzhuk
2014-11-04 16:46 ` Tom Rini
2014-11-05 21:32 ` [U-Boot] [U-Boot, U-boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.