* [PATCH] mfd: Fix cs5535 dependencies
@ 2014-03-07 21:00 Jean Delvare
2014-03-07 21:25 ` One Thousand Gnomes
0 siblings, 1 reply; 5+ messages in thread
From: Jean Delvare @ 2014-03-07 21:00 UTC (permalink / raw
To: LKML; +Cc: Samuel Ortiz, Lee Jones
As far as I know, the CS5535 and CS5536 chipsets are companions of the
Geode series of processors, which are 32-bit only. So the CS5535
drivers are not needed on x86-64, except for build testing purpose.
This aligns the dependencies to what FB_GEODE already uses.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-3.14-rc5.orig/drivers/mfd/Kconfig 2014-03-07 21:43:13.739818995 +0100
+++ linux-3.14-rc5/drivers/mfd/Kconfig 2014-03-07 21:43:59.262786389 +0100
@@ -13,7 +13,7 @@ config MFD_CORE
config MFD_CS5535
tristate "AMD CS5535 and CS5536 southbridge core functions"
select MFD_CORE
- depends on PCI && X86
+ depends on PCI && (X86_32 || (X86 && COMPILE_TEST))
---help---
This is the core driver for CS5535/CS5536 MFD functions. This is
necessary for using the board's GPIO and MFGPT functionality.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mfd: Fix cs5535 dependencies
2014-03-07 21:00 [PATCH] mfd: Fix cs5535 dependencies Jean Delvare
@ 2014-03-07 21:25 ` One Thousand Gnomes
2014-03-10 8:54 ` Lee Jones
2014-03-10 15:56 ` Jean Delvare
0 siblings, 2 replies; 5+ messages in thread
From: One Thousand Gnomes @ 2014-03-07 21:25 UTC (permalink / raw
To: Jean Delvare; +Cc: LKML, Samuel Ortiz, Lee Jones
On Fri, 7 Mar 2014 22:00:51 +0100
Jean Delvare <jdelvare@suse.de> wrote:
> As far as I know, the CS5535 and CS5536 chipsets are companions of the
> Geode series of processors, which are 32-bit only. So the CS5535
> drivers are not needed on x86-64, except for build testing purpose.
>
> This aligns the dependencies to what FB_GEODE already uses.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
This looks correct to me. Also true for the ATA driver and a few others
plus for the CS5510 and 5520.
Alan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mfd: Fix cs5535 dependencies
2014-03-07 21:25 ` One Thousand Gnomes
@ 2014-03-10 8:54 ` Lee Jones
2014-03-10 15:56 ` Jean Delvare
1 sibling, 0 replies; 5+ messages in thread
From: Lee Jones @ 2014-03-10 8:54 UTC (permalink / raw
To: One Thousand Gnomes; +Cc: Jean Delvare, LKML, Samuel Ortiz
> Jean Delvare <jdelvare@suse.de> wrote:
>
> > As far as I know, the CS5535 and CS5536 chipsets are companions of the
> > Geode series of processors, which are 32-bit only. So the CS5535
> > drivers are not needed on x86-64, except for build testing purpose.
> >
> > This aligns the dependencies to what FB_GEODE already uses.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
>
> This looks correct to me. Also true for the ATA driver and a few others
> plus for the CS5510 and 5520.
Is that an Ack Alan?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mfd: Fix cs5535 dependencies
2014-03-07 21:25 ` One Thousand Gnomes
2014-03-10 8:54 ` Lee Jones
@ 2014-03-10 15:56 ` Jean Delvare
2014-03-10 17:28 ` Jean Delvare
1 sibling, 1 reply; 5+ messages in thread
From: Jean Delvare @ 2014-03-10 15:56 UTC (permalink / raw
To: One Thousand Gnomes; +Cc: LKML, Samuel Ortiz, Lee Jones
Le Friday 07 March 2014 à 21:25 +0000, One Thousand Gnomes a écrit :
> On Fri, 7 Mar 2014 22:00:51 +0100
> Jean Delvare <jdelvare@suse.de> wrote:
>
> > As far as I know, the CS5535 and CS5536 chipsets are companions of the
> > Geode series of processors, which are 32-bit only. So the CS5535
> > drivers are not needed on x86-64, except for build testing purpose.
> >
> > This aligns the dependencies to what FB_GEODE already uses.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
>
> This looks correct to me. Also true for the ATA driver and a few others
> plus for the CS5510 and 5520.
And probably CONFIG_GEODE_WDT and CONFIG_SND_CS5535AUDIO as well?
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mfd: Fix cs5535 dependencies
2014-03-10 15:56 ` Jean Delvare
@ 2014-03-10 17:28 ` Jean Delvare
0 siblings, 0 replies; 5+ messages in thread
From: Jean Delvare @ 2014-03-10 17:28 UTC (permalink / raw
To: One Thousand Gnomes; +Cc: LKML, Samuel Ortiz, Lee Jones
Le Monday 10 March 2014 à 16:56 +0100, Jean Delvare a écrit :
> Le Friday 07 March 2014 à 21:25 +0000, One Thousand Gnomes a écrit :
> > On Fri, 7 Mar 2014 22:00:51 +0100
> > Jean Delvare <jdelvare@suse.de> wrote:
> >
> > > As far as I know, the CS5535 and CS5536 chipsets are companions of the
> > > Geode series of processors, which are 32-bit only. So the CS5535
> > > drivers are not needed on x86-64, except for build testing purpose.
> > >
> > > This aligns the dependencies to what FB_GEODE already uses.
> > >
> > > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> >
> > This looks correct to me. Also true for the ATA driver and a few others
> > plus for the CS5510 and 5520.
>
> And probably CONFIG_GEODE_WDT and CONFIG_SND_CS5535AUDIO as well?
... and CONFIG_PATA_CS5530?
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-03-10 17:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-07 21:00 [PATCH] mfd: Fix cs5535 dependencies Jean Delvare
2014-03-07 21:25 ` One Thousand Gnomes
2014-03-10 8:54 ` Lee Jones
2014-03-10 15:56 ` Jean Delvare
2014-03-10 17:28 ` Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.