* [PATCH 1/3] ASoC: Remove unused control_type field from snd_soc_codec struct
@ 2013-08-31 9:02 Lars-Peter Clausen
2013-08-31 9:02 ` [PATCH 2/3] ASoC: Remove unused debugfs_dapm field from snd_soc_{platform, codec} struct Lars-Peter Clausen
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lars-Peter Clausen @ 2013-08-31 9:02 UTC (permalink / raw
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, Lars-Peter Clausen
The control_type field was used by the core to track which raw IO methods to
use, but when switching to regmap this was no longer necessary and so the last
user of the field was removed in commit be3ea3b9 ("ASoC: Use new register map
API for ASoC generic physical I/O"). The field is now completely unused and can
be removed.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
include/sound/soc.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/sound/soc.h b/include/sound/soc.h
index 8e2ad52..9d4c2ab 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -705,7 +705,6 @@ struct snd_soc_codec {
/* codec IO */
void *control_data; /* codec control (i2c/3wire) data */
- enum snd_soc_control_type control_type;
hw_write_t hw_write;
unsigned int (*hw_read)(struct snd_soc_codec *, unsigned int);
unsigned int (*read)(struct snd_soc_codec *, unsigned int);
--
1.8.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] ASoC: Remove unused debugfs_dapm field from snd_soc_{platform, codec} struct
2013-08-31 9:02 [PATCH 1/3] ASoC: Remove unused control_type field from snd_soc_codec struct Lars-Peter Clausen
@ 2013-08-31 9:02 ` Lars-Peter Clausen
2013-08-31 9:02 ` [PATCH 3/3] ASoC: Remove unused sysfs_registered field from snd_soc_codec struct Lars-Peter Clausen
2013-08-31 11:48 ` [PATCH 1/3] ASoC: Remove unused control_type " Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Lars-Peter Clausen @ 2013-08-31 9:02 UTC (permalink / raw
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, Lars-Peter Clausen
The DAPM context struct has its own field where it stores the pointer to the
DAPM debugfs entry. The debugfs_dapm field in the snd_soc_platform and
snd_soc_codec structs are completely unused and can be removed.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
include/sound/soc.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/sound/soc.h b/include/sound/soc.h
index 9d4c2ab..79b305d 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -723,7 +723,6 @@ struct snd_soc_codec {
#ifdef CONFIG_DEBUG_FS
struct dentry *debugfs_codec_root;
struct dentry *debugfs_reg;
- struct dentry *debugfs_dapm;
#endif
};
@@ -848,7 +847,6 @@ struct snd_soc_platform {
#ifdef CONFIG_DEBUG_FS
struct dentry *debugfs_platform_root;
- struct dentry *debugfs_dapm;
#endif
};
--
1.8.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] ASoC: Remove unused sysfs_registered field from snd_soc_codec struct
2013-08-31 9:02 [PATCH 1/3] ASoC: Remove unused control_type field from snd_soc_codec struct Lars-Peter Clausen
2013-08-31 9:02 ` [PATCH 2/3] ASoC: Remove unused debugfs_dapm field from snd_soc_{platform, codec} struct Lars-Peter Clausen
@ 2013-08-31 9:02 ` Lars-Peter Clausen
2013-08-31 11:48 ` [PATCH 1/3] ASoC: Remove unused control_type " Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Lars-Peter Clausen @ 2013-08-31 9:02 UTC (permalink / raw
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, Lars-Peter Clausen
The sysfs_registered field was added to the snd_soc_codec struct in commit
f0fba2ad ("ASoC: multi-component - ASoC Multi-Component Support"), but has never
been used.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
include/sound/soc.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/sound/soc.h b/include/sound/soc.h
index 79b305d..7184805 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -697,7 +697,6 @@ struct snd_soc_codec {
unsigned int probed:1; /* Codec has been probed */
unsigned int ac97_registered:1; /* Codec has been AC97 registered */
unsigned int ac97_created:1; /* Codec has been created by SoC */
- unsigned int sysfs_registered:1; /* codec has been sysfs registered */
unsigned int cache_init:1; /* codec cache has been initialized */
unsigned int using_regmap:1; /* using regmap access */
u32 cache_only; /* Suppress writes to hardware */
--
1.8.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] ASoC: Remove unused control_type field from snd_soc_codec struct
2013-08-31 9:02 [PATCH 1/3] ASoC: Remove unused control_type field from snd_soc_codec struct Lars-Peter Clausen
2013-08-31 9:02 ` [PATCH 2/3] ASoC: Remove unused debugfs_dapm field from snd_soc_{platform, codec} struct Lars-Peter Clausen
2013-08-31 9:02 ` [PATCH 3/3] ASoC: Remove unused sysfs_registered field from snd_soc_codec struct Lars-Peter Clausen
@ 2013-08-31 11:48 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2013-08-31 11:48 UTC (permalink / raw
To: Lars-Peter Clausen; +Cc: alsa-devel, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 426 bytes --]
On Sat, Aug 31, 2013 at 11:02:17AM +0200, Lars-Peter Clausen wrote:
> The control_type field was used by the core to track which raw IO methods to
> use, but when switching to regmap this was no longer necessary and so the last
> user of the field was removed in commit be3ea3b9 ("ASoC: Use new register map
> API for ASoC generic physical I/O"). The field is now completely unused and can
> be removed.
Applied all, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-31 11:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-31 9:02 [PATCH 1/3] ASoC: Remove unused control_type field from snd_soc_codec struct Lars-Peter Clausen
2013-08-31 9:02 ` [PATCH 2/3] ASoC: Remove unused debugfs_dapm field from snd_soc_{platform, codec} struct Lars-Peter Clausen
2013-08-31 9:02 ` [PATCH 3/3] ASoC: Remove unused sysfs_registered field from snd_soc_codec struct Lars-Peter Clausen
2013-08-31 11:48 ` [PATCH 1/3] ASoC: Remove unused control_type " Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.