* [Buildroot] [PATCH] gpsd: dbus interface requires dbus-glib
@ 2012-03-04 23:16 Arnout Vandecappelle
2012-03-06 22:07 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Arnout Vandecappelle @ 2012-03-04 23:16 UTC (permalink / raw
To: buildroot
gpsd uses dbus-glib as the dbus interface, so it should only be built if
libglib2 has been selected. To simplify things, build dbus support only
if dbus-glib is selected.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
v2:
The select of DBUS_GLIB in Config.in created a circular dependency. So
I simplified things by looking at DBUS_GLIB instead of DBUS for automatic
enabling of dbus support.
Also added help text to explain this.
package/gpsd/Config.in | 2 ++
package/gpsd/gpsd.mk | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/gpsd/Config.in b/package/gpsd/Config.in
index d387abd..16635dc 100644
--- a/package/gpsd/Config.in
+++ b/package/gpsd/Config.in
@@ -8,6 +8,8 @@ config BR2_PACKAGE_GPSD
making all data on the location/course/velocity of the sensors
available to be queried on TCP port 2947 of the host computer.
+ The D-Bus interface is included if dbus-glib is enabled.
+
http://gpsd.berlios.de/
config BR2_PACKAGE_GPSD_DEVICES
diff --git a/package/gpsd/gpsd.mk b/package/gpsd/gpsd.mk
index be6daeb..94f39aa 100644
--- a/package/gpsd/gpsd.mk
+++ b/package/gpsd/gpsd.mk
@@ -30,9 +30,9 @@ ifeq ($(BR2_PACKAGE_LIBUSB),y)
GPSD_DEPENDENCIES += libusb
endif
-ifeq ($(strip $(BR2_PACKAGE_DBUS)),y)
+ifeq ($(BR2_PACKAGE_DBUS_GLIB),y)
GPSD_CONF_OPT += --enable-dbus
- GPSD_DEPENDENCIES += dbus dbus-glib
+ GPSD_DEPENDENCIES += dbus-glib
endif
ifeq ($(BR2_PACKAGE_NCURSES),y)
--
tg: (15fe220..) t/gpsd (depends on: master)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] gpsd: dbus interface requires dbus-glib
2012-03-04 23:16 [Buildroot] [PATCH] gpsd: dbus interface requires dbus-glib Arnout Vandecappelle
@ 2012-03-06 22:07 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2012-03-06 22:07 UTC (permalink / raw
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
Arnout> gpsd uses dbus-glib as the dbus interface, so it should only be
Arnout> built if libglib2 has been selected. To simplify things, build
Arnout> dbus support only if dbus-glib is selected.
Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Arnout> ---
Arnout> v2:
Arnout> The select of DBUS_GLIB in Config.in created a circular
Arnout> dependency.
Committed, thanks. It makes it easier for me if you also add [PATCHv2]
in the subject, so I can easily see this replaces your earlier patch.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-06 22:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-04 23:16 [Buildroot] [PATCH] gpsd: dbus interface requires dbus-glib Arnout Vandecappelle
2012-03-06 22:07 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.