From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Matt Carlson <mcarlson@broadcom.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
Maciej Rutecki <maciej.rutecki@gmail.com>,
Florian Mickler <florian@mickler.org>,
Michael Chan <mchan@broadcom.com>,
Ben Hutchings <bhutchings@solarflare.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1
Date: Tue, 28 Feb 2012 18:58:36 -0600 [thread overview]
Message-ID: <1330477116.2822.191.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <20120228233225.GA1322@mcarlson.broadcom.com>
On Tue, 2012-02-28 at 15:32 -0800, Matt Carlson wrote:
> On Mon, Feb 27, 2012 at 05:44:34PM -0600, James Bottomley wrote:
> > On Thu, 2012-02-23 at 23:55 +0100, Rafael J. Wysocki wrote:
> > > This message has been generated automatically as a part of a summary report
> > > of recent regressions.
> > >
> > > The following bug entry is on the current list of known regressions
> > > from 3.2. Please verify if it still should be listed and let the tracking team
> > > know (either way).
> > >
> > >
> > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=42707
> > > Subject : Hang deconfiguring network interface (in shutdown) on 3.3-rc1
> > > Submitter : James Bottomley <James.Bottomley@hansenpartnership.com>
> > > Date : 2012-01-28 19:56 (27 days old)
> > > Message-ID : <1327780565.2924.24.camel@dabdike.int.hansenpartnership.com>
> > > References : http://marc.info/?l=linux-kernel&m=132778076214873&w=2
> >
> > Still present in 3.3-rc4; I've bisected it back to this commit:
> >
> > commit 92feeabf3f673767c6ee4cfc7fc224098446c1c1
> > Author: Matt Carlson <mcarlson@broadcom.com>
> > Date: Thu Dec 8 14:40:14 2011 +0000
> >
> > tg3: Save stats across chip resets
> >
> > and sure enough, just reverting this single commit on 3.3-rc4 fixes the
> > problem.
> >
> > James
>
> Are you dealing with a bcm5700 or bcm5701 device?
Yes, this is it:
20:02.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5701 Gigabit Ethernet (rev 15)
Subsystem: Hewlett-Packard Company Core Lan 1000Base-T
Flags: bus master, 66MHz, medium devsel, latency 128, IRQ 72
Memory at ffffffff90000000 (64-bit, non-prefetchable) [size=64K]
Capabilities: [40] PCI-X non-bridge device
Capabilities: [48] Power Management version 2
Capabilities: [50] Vital Product Data
Capabilities: [58] MSI: Enable- Count=1/8 Maskable- 64bit+
Kernel driver in use: tg3
> If so, can you try
> the following patch?
>
> Subject: [PATCH 1/1] tg3: Fix tg3_get_stats64 for 5700 / 5701 devs
Well, the patch needs some attention:
CC [M] drivers/net/ethernet/broadcom/tg3.o
drivers/net/ethernet/broadcom/tg3.c: In function 'tg3_get_estats':
drivers/net/ethernet/broadcom/tg3.c:9882: warning: 'return' with a value, in function returning void
It also didn't apply incredibly well (the fuzz factors and line offsets
are a lot higher than they should be):
patching file drivers/net/ethernet/broadcom/tg3.c
Hunk #1 succeeded at 7886 (offset -115 lines).
Hunk #2 succeeded at 7908 (offset -115 lines).
Hunk #3 succeeded at 9845 (offset -278 lines).
Hunk #4 succeeded at 9854 (offset -278 lines).
Hunk #5 succeeded at 9873 (offset -278 lines).
Hunk #6 succeeded at 9958 (offset -275 lines).
Hunk #7 succeeded at 10007 with fuzz 1 (offset -275 lines).
Hunk #8 succeeded at 10103 with fuzz 2 (offset -2096 lines).
but it seems to work.
Thanks,
James
WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
To: Matt Carlson <mcarlson-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Kernel Testers List
<kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Maciej Rutecki
<maciej.rutecki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Florian Mickler <florian-sVu6HhrpSfRAfugRpC6u6w@public.gmane.org>,
Michael Chan <mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Ben Hutchings
<bhutchings-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1
Date: Tue, 28 Feb 2012 18:58:36 -0600 [thread overview]
Message-ID: <1330477116.2822.191.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <20120228233225.GA1322-+O+RPeR0w/SWJtbYL5oUVDJtLkR7yuzc@public.gmane.org>
On Tue, 2012-02-28 at 15:32 -0800, Matt Carlson wrote:
> On Mon, Feb 27, 2012 at 05:44:34PM -0600, James Bottomley wrote:
> > On Thu, 2012-02-23 at 23:55 +0100, Rafael J. Wysocki wrote:
> > > This message has been generated automatically as a part of a summary report
> > > of recent regressions.
> > >
> > > The following bug entry is on the current list of known regressions
> > > from 3.2. Please verify if it still should be listed and let the tracking team
> > > know (either way).
> > >
> > >
> > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=42707
> > > Subject : Hang deconfiguring network interface (in shutdown) on 3.3-rc1
> > > Submitter : James Bottomley <James.Bottomley-JuX6DAaQMKPCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
> > > Date : 2012-01-28 19:56 (27 days old)
> > > Message-ID : <1327780565.2924.24.camel-sFMDBYUN5F8GjUHQrlYNx2Wm91YjaHnnhRte9Li2A+AAvxtiuMwx3w@public.gmane.org>
> > > References : http://marc.info/?l=linux-kernel&m=132778076214873&w=2
> >
> > Still present in 3.3-rc4; I've bisected it back to this commit:
> >
> > commit 92feeabf3f673767c6ee4cfc7fc224098446c1c1
> > Author: Matt Carlson <mcarlson-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> > Date: Thu Dec 8 14:40:14 2011 +0000
> >
> > tg3: Save stats across chip resets
> >
> > and sure enough, just reverting this single commit on 3.3-rc4 fixes the
> > problem.
> >
> > James
>
> Are you dealing with a bcm5700 or bcm5701 device?
Yes, this is it:
20:02.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5701 Gigabit Ethernet (rev 15)
Subsystem: Hewlett-Packard Company Core Lan 1000Base-T
Flags: bus master, 66MHz, medium devsel, latency 128, IRQ 72
Memory at ffffffff90000000 (64-bit, non-prefetchable) [size=64K]
Capabilities: [40] PCI-X non-bridge device
Capabilities: [48] Power Management version 2
Capabilities: [50] Vital Product Data
Capabilities: [58] MSI: Enable- Count=1/8 Maskable- 64bit+
Kernel driver in use: tg3
> If so, can you try
> the following patch?
>
> Subject: [PATCH 1/1] tg3: Fix tg3_get_stats64 for 5700 / 5701 devs
Well, the patch needs some attention:
CC [M] drivers/net/ethernet/broadcom/tg3.o
drivers/net/ethernet/broadcom/tg3.c: In function 'tg3_get_estats':
drivers/net/ethernet/broadcom/tg3.c:9882: warning: 'return' with a value, in function returning void
It also didn't apply incredibly well (the fuzz factors and line offsets
are a lot higher than they should be):
patching file drivers/net/ethernet/broadcom/tg3.c
Hunk #1 succeeded at 7886 (offset -115 lines).
Hunk #2 succeeded at 7908 (offset -115 lines).
Hunk #3 succeeded at 9845 (offset -278 lines).
Hunk #4 succeeded at 9854 (offset -278 lines).
Hunk #5 succeeded at 9873 (offset -278 lines).
Hunk #6 succeeded at 9958 (offset -275 lines).
Hunk #7 succeeded at 10007 with fuzz 1 (offset -275 lines).
Hunk #8 succeeded at 10103 with fuzz 2 (offset -2096 lines).
but it seems to work.
Thanks,
James
next prev parent reply other threads:[~2012-02-29 0:58 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 22:51 3.3-rc4+: Reported regressions from 3.2 Rafael J. Wysocki
2012-02-23 22:51 ` Rafael J. Wysocki
2012-02-23 22:51 ` [Bug #42669] 3.3-rc1: compiling problems nvme , l2cap_sock , mc13892-regulator , and snd-pcsp don't work Rafael J. Wysocki
2012-02-23 23:19 ` David Miller
2012-02-23 23:19 ` David Miller
2012-02-23 23:30 ` Rafael J. Wysocki
2012-02-23 23:30 ` Rafael J. Wysocki
2012-02-24 10:48 ` werner
2012-02-24 19:57 ` David Miller
2012-02-24 19:57 ` David Miller
2012-02-24 21:55 ` werner
2012-02-24 21:55 ` werner
2012-02-25 22:48 ` Florian Mickler
2012-02-23 22:55 ` [Bug #42686] iwlagn is getting even worse with 3.3-rc1 Rafael J. Wysocki
2012-02-23 22:55 ` Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1 Rafael J. Wysocki
2012-02-27 23:44 ` James Bottomley
2012-02-28 1:24 ` Matt Carlson
2012-02-28 21:07 ` David Miller
2012-02-28 21:07 ` David Miller
2012-02-28 23:32 ` Matt Carlson
2012-02-28 23:32 ` Matt Carlson
2012-02-29 0:58 ` James Bottomley [this message]
2012-02-29 0:58 ` James Bottomley
2012-02-29 9:33 ` Michael Chan
2012-02-29 18:46 ` David Miller
2012-02-29 18:46 ` David Miller
2012-02-23 22:55 ` [Bug #42678] [3.3-rc1] radeon stuck in kernel after lockup Rafael J. Wysocki
2012-02-24 9:14 ` Torsten Kaiser
2012-02-24 9:14 ` Torsten Kaiser
2012-02-23 22:55 ` [Bug #42683] WARN... Device 'cpu1' does not have a release() function, it is broken and must be fixed. when doing 'xl vcpu-set <guest_id> 1' Rafael J. Wysocki
2012-02-23 22:55 ` Rafael J. Wysocki
2012-02-24 4:33 ` Konrad Rzeszutek Wilk
2012-02-24 4:33 ` Konrad Rzeszutek Wilk
2012-02-23 22:55 ` [Bug #42713] Regression in skge that started around acb42a3 (so past v3.3-rc1) Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42734] dosemu graphics broken in v3.3-rc1 Rafael J. Wysocki
2012-02-23 22:55 ` Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42746] 3.3-rc2 snd_pcm lockdep backtrace Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42735] kobject (ffff88003ffbb4b8): tried to init an initialized object, something is seriously wrong Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42733] Regression 3.2 -> 3.3-rc1 10 sec hang at boot and resume, COMRESET failed Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42761] Possible circular locking dependency (3.3-rc2) Rafael J. Wysocki
2012-02-23 22:55 ` Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42798] i915 regression with 3.3-rc3+git Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42776] OF-related boot crash in 3.3.0-rc3-00188-g3ec1e88 Rafael J. Wysocki
2012-02-23 23:28 ` 3.3-rc4+: Reported regressions from 3.2 David Miller
2012-02-23 23:28 ` David Miller
2012-02-24 0:13 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2012-03-04 20:29 3.3-rc6: " Rafael J. Wysocki
2012-03-04 20:31 ` [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1 Rafael J. Wysocki
2012-03-04 20:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330477116.2822.191.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=florian@mickler.org \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.