* [U-Boot] [PATCH] fix nfs symlink name corruption
@ 2009-11-19 8:47 Ed Swarthout
2009-12-07 20:17 ` Wolfgang Denk
0 siblings, 1 reply; 3+ messages in thread
From: Ed Swarthout @ 2009-11-19 8:47 UTC (permalink / raw
To: u-boot
An off by one error may cause nfs readlink lookup fail if
nfs_path_buff has non-zero data from a previous use.
Loading: *** ERROR: File lookup fail
Signed-off-by: Ed Swarthout <Ed.Swarthout@freescale.com>
---
net/nfs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/nfs.c b/net/nfs.c
index 27395fb..c39f616 100644
--- a/net/nfs.c
+++ b/net/nfs.c
@@ -516,7 +516,7 @@ nfs_readlink_reply (uchar *pkt, unsigned len)
strcat (nfs_path, "/");
pathlen = strlen(nfs_path);
memcpy (nfs_path+pathlen, (uchar *)&(rpc_pkt.u.reply.data[2]), rlen);
- nfs_path[pathlen+rlen+1] = 0;
+ nfs_path[pathlen + rlen] = 0;
} else {
memcpy (nfs_path, (uchar *)&(rpc_pkt.u.reply.data[2]), rlen);
nfs_path[rlen] = 0;
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] fix nfs symlink name corruption
2009-11-19 8:47 [U-Boot] [PATCH] fix nfs symlink name corruption Ed Swarthout
@ 2009-12-07 20:17 ` Wolfgang Denk
2009-12-07 20:40 ` Ben Warren
0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Denk @ 2009-12-07 20:17 UTC (permalink / raw
To: u-boot
Dear Ed Swarthout,
In message <1258620448-20960-1-git-send-email-Ed.Swarthout@freescale.com> you wrote:
> An off by one error may cause nfs readlink lookup fail if
> nfs_path_buff has non-zero data from a previous use.
>
> Loading: *** ERROR: File lookup fail
>
> Signed-off-by: Ed Swarthout <Ed.Swarthout@freescale.com>
> ---
> net/nfs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied.
Ben, I hope this is OK with you. Looked obvious to me.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I can't understand it. I can't even understand the people who can
understand it. - Queen Juliana of the Netherlands.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] fix nfs symlink name corruption
2009-12-07 20:17 ` Wolfgang Denk
@ 2009-12-07 20:40 ` Ben Warren
0 siblings, 0 replies; 3+ messages in thread
From: Ben Warren @ 2009-12-07 20:40 UTC (permalink / raw
To: u-boot
Wolfgang Denk wrote:
> Dear Ed Swarthout,
>
> In message <1258620448-20960-1-git-send-email-Ed.Swarthout@freescale.com> you wrote:
>
>> An off by one error may cause nfs readlink lookup fail if
>> nfs_path_buff has non-zero data from a previous use.
>>
>> Loading: *** ERROR: File lookup fail
>>
>> Signed-off-by: Ed Swarthout <Ed.Swarthout@freescale.com>
>> ---
>> net/nfs.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>
> Applied.
>
> Ben, I hope this is OK with you. Looked obvious to me.
>
> Best regards,
>
> Wolfgang Denk
>
>
Fine with me. Thanks for taking care of this.
Ben
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-07 20:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-19 8:47 [U-Boot] [PATCH] fix nfs symlink name corruption Ed Swarthout
2009-12-07 20:17 ` Wolfgang Denk
2009-12-07 20:40 ` Ben Warren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.