* [PATCH JGIT] fix typo
@ 2009-01-31 14:26 Yann Simon
2009-01-31 16:45 ` Robin Rosenberg
2009-02-01 12:42 ` Baz
0 siblings, 2 replies; 3+ messages in thread
From: Yann Simon @ 2009-01-31 14:26 UTC (permalink / raw
To: Shawn O. Pearce, Robin Rosenberg; +Cc: git
fix a little typo
Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>
---
.../src/org/spearce/jgit/lib/WindowedFile.java | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java
b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java
index 5eb8465..1ff8caa 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java
@@ -61,7 +61,7 @@
* before any single byte can be accessed.
* </p>
* <p>
- * Using a specific MapMode will avoid the complete copy by mmaping in
the
+ * Using a specific MapMode will avoid the complete copy by mapping in
the
* operating system's file buffers, however this may cause problems if
a large
* number of windows are being heavily accessed as the Java garbage
collector
* may not be able to unmap old windows fast enough to permit new
windows to be
--
1.6.0.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH JGIT] fix typo
2009-01-31 14:26 [PATCH JGIT] fix typo Yann Simon
@ 2009-01-31 16:45 ` Robin Rosenberg
2009-02-01 12:42 ` Baz
1 sibling, 0 replies; 3+ messages in thread
From: Robin Rosenberg @ 2009-01-31 16:45 UTC (permalink / raw
To: Yann Simon; +Cc: Shawn O. Pearce, git
lördag 31 januari 2009 15:26:07 skrev Yann Simon:
> fix a little typo
> Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>
> ---
> .../src/org/spearce/jgit/lib/WindowedFile.java | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Cleanups are nice too, but please try to follow the existing
style when it comes to comments. I don't think we have
stated these implicit rules anywhere.
- New sentences start with a capital letter.
- Don't repeat yourself You do not need a body in the comment
if the first line says it all, except the SOB line which technically
is part of the body.
- Make sure there is an empty line before the SOB line.
Cheers,
-- robin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH JGIT] fix typo
2009-01-31 14:26 [PATCH JGIT] fix typo Yann Simon
2009-01-31 16:45 ` Robin Rosenberg
@ 2009-02-01 12:42 ` Baz
1 sibling, 0 replies; 3+ messages in thread
From: Baz @ 2009-02-01 12:42 UTC (permalink / raw
To: Yann Simon; +Cc: Shawn O. Pearce, Robin Rosenberg, git
2009/1/31 Yann Simon <yann.simon.fr@gmail.com>:
> fix a little typo
> Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>
> ---
> .../src/org/spearce/jgit/lib/WindowedFile.java | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java
> b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java
> index 5eb8465..1ff8caa 100644
> --- a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java
> +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java
> @@ -61,7 +61,7 @@
> * before any single byte can be accessed.
> * </p>
> * <p>
> - * Using a specific MapMode will avoid the complete copy by mmaping in
> the
> + * Using a specific MapMode will avoid the complete copy by mapping in
Is this actually a typo? java.nio being used to mmap() files here (see
the later use of mmap in this class), its more informative and common
to use the double m to describe that. I'd have said the typo was at
the end of the comment, ie "fast enough to permit new windows to be
mapped." should read "fast enough to permit new windows to be
mmapped."
> the
> * operating system's file buffers, however this may cause problems if
> a large
> * number of windows are being heavily accessed as the Java garbage
> collector
> * may not be able to unmap old windows fast enough to permit new
> windows to be
> --
> 1.6.0.6
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-01 12:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-31 14:26 [PATCH JGIT] fix typo Yann Simon
2009-01-31 16:45 ` Robin Rosenberg
2009-02-01 12:42 ` Baz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.