* [PATCH 1/1] NET: net_namespace, fix lock imbalance
@ 2009-01-17 16:47 Jiri Slaby
2009-01-18 7:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2009-01-17 16:47 UTC (permalink / raw
To: davem; +Cc: netdev, linux-kernel, Jiri Slaby, Alexey Dobriyan
register_pernet_gen_subsys omits mutex_unlock in one fail path.
Fix it.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
---
net/core/net_namespace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
index 55cffad..55151fa 100644
--- a/net/core/net_namespace.c
+++ b/net/core/net_namespace.c
@@ -341,8 +341,8 @@ again:
rv = register_pernet_operations(first_device, ops);
if (rv < 0)
ida_remove(&net_generic_ids, *id);
- mutex_unlock(&net_mutex);
out:
+ mutex_unlock(&net_mutex);
return rv;
}
EXPORT_SYMBOL_GPL(register_pernet_gen_subsys);
--
1.6.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] NET: net_namespace, fix lock imbalance
2009-01-17 16:47 [PATCH 1/1] NET: net_namespace, fix lock imbalance Jiri Slaby
@ 2009-01-18 7:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-01-18 7:08 UTC (permalink / raw
To: jirislaby; +Cc: netdev, linux-kernel, adobriyan
From: Jiri Slaby <jirislaby@gmail.com>
Date: Sat, 17 Jan 2009 17:47:12 +0100
> register_pernet_gen_subsys omits mutex_unlock in one fail path.
> Fix it.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-18 7:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-17 16:47 [PATCH 1/1] NET: net_namespace, fix lock imbalance Jiri Slaby
2009-01-18 7:08 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.