* [PATCH 1/3] regulator: core: Fix checkpatch issue
@ 2014-01-08 1:02 Jingoo Han
2014-01-08 1:03 ` [PATCH 2/3] regulator: mc13892: " Jingoo Han
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Jingoo Han @ 2014-01-08 1:02 UTC (permalink / raw
To: 'Mark Brown'
Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han'
Fix the following checkpatch errors and warnings.
ERROR: trailing whitespace
ERROR: return is not a function, parentheses are not required
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/regulator/core.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 9888f26..b38a6b6 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1334,9 +1334,8 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
* If we have return value from dev_lookup fail, we do not expect to
* succeed, so, quit with appropriate error value
*/
- if (ret && ret != -ENODEV) {
+ if (ret && ret != -ENODEV)
goto out;
- }
if (!devname)
devname = "deviceless";
@@ -2245,7 +2244,7 @@ int regulator_is_supported_voltage(struct regulator *regulator,
if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE)) {
ret = regulator_get_voltage(regulator);
if (ret >= 0)
- return (min_uV <= ret && ret <= max_uV);
+ return min_uV <= ret && ret <= max_uV;
else
return ret;
}
@@ -2417,7 +2416,7 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
ret = regulator_check_voltage(rdev, &min_uV, &max_uV);
if (ret < 0)
goto out;
-
+
/* restore original values in case of error */
old_min_uV = regulator->min_uV;
old_max_uV = regulator->max_uV;
@@ -2431,7 +2430,7 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
if (ret < 0)
goto out2;
-
+
out:
mutex_unlock(&rdev->mutex);
return ret;
@@ -3836,9 +3835,8 @@ static int __init regulator_init_complete(void)
* goes wrong. */
rdev_info(rdev, "disabling\n");
ret = ops->disable(rdev);
- if (ret != 0) {
+ if (ret != 0)
rdev_err(rdev, "couldn't disable: %d\n", ret);
- }
} else {
/* The intention is that in future we will
* assume that full constraints are provided
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] regulator: mc13892: Fix checkpatch issue
2014-01-08 1:02 [PATCH 1/3] regulator: core: Fix checkpatch issue Jingoo Han
@ 2014-01-08 1:03 ` Jingoo Han
2014-01-08 17:15 ` Mark Brown
2014-01-08 1:04 ` [PATCH 3/3] regulator: twl: " Jingoo Han
2014-01-08 17:14 ` [PATCH 1/3] regulator: core: " Mark Brown
2 siblings, 1 reply; 7+ messages in thread
From: Jingoo Han @ 2014-01-08 1:03 UTC (permalink / raw
To: 'Mark Brown'
Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han',
'Sascha Hauer'
Fix the following checkpatch warnings.
WARNING: Avoid unnecessary line continuations
WARNING: line over 80 characters
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/regulator/mc13892-regulator.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
index 96c9f80..f374fa5 100644
--- a/drivers/regulator/mc13892-regulator.c
+++ b/drivers/regulator/mc13892-regulator.c
@@ -274,25 +274,25 @@ static struct mc13xxx_regulator mc13892_regulators[] = {
MC13892_SW_DEFINE(SW4, SWITCHERS3, SWITCHERS3, mc13892_sw),
MC13892_FIXED_DEFINE(SWBST, SWITCHERS5, mc13892_swbst),
MC13892_FIXED_DEFINE(VIOHI, REGULATORMODE0, mc13892_viohi),
- MC13892_DEFINE_REGU(VPLL, REGULATORMODE0, REGULATORSETTING0, \
+ MC13892_DEFINE_REGU(VPLL, REGULATORMODE0, REGULATORSETTING0,
mc13892_vpll),
- MC13892_DEFINE_REGU(VDIG, REGULATORMODE0, REGULATORSETTING0, \
+ MC13892_DEFINE_REGU(VDIG, REGULATORMODE0, REGULATORSETTING0,
mc13892_vdig),
- MC13892_DEFINE_REGU(VSD, REGULATORMODE1, REGULATORSETTING1, \
+ MC13892_DEFINE_REGU(VSD, REGULATORMODE1, REGULATORSETTING1,
mc13892_vsd),
- MC13892_DEFINE_REGU(VUSB2, REGULATORMODE0, REGULATORSETTING0, \
+ MC13892_DEFINE_REGU(VUSB2, REGULATORMODE0, REGULATORSETTING0,
mc13892_vusb2),
- MC13892_DEFINE_REGU(VVIDEO, REGULATORMODE1, REGULATORSETTING1, \
+ MC13892_DEFINE_REGU(VVIDEO, REGULATORMODE1, REGULATORSETTING1,
mc13892_vvideo),
- MC13892_DEFINE_REGU(VAUDIO, REGULATORMODE1, REGULATORSETTING1, \
+ MC13892_DEFINE_REGU(VAUDIO, REGULATORMODE1, REGULATORSETTING1,
mc13892_vaudio),
- MC13892_DEFINE_REGU(VCAM, REGULATORMODE1, REGULATORSETTING0, \
+ MC13892_DEFINE_REGU(VCAM, REGULATORMODE1, REGULATORSETTING0,
mc13892_vcam),
- MC13892_DEFINE_REGU(VGEN1, REGULATORMODE0, REGULATORSETTING0, \
+ MC13892_DEFINE_REGU(VGEN1, REGULATORMODE0, REGULATORSETTING0,
mc13892_vgen1),
- MC13892_DEFINE_REGU(VGEN2, REGULATORMODE0, REGULATORSETTING0, \
+ MC13892_DEFINE_REGU(VGEN2, REGULATORMODE0, REGULATORSETTING0,
mc13892_vgen2),
- MC13892_DEFINE_REGU(VGEN3, REGULATORMODE1, REGULATORSETTING0, \
+ MC13892_DEFINE_REGU(VGEN3, REGULATORMODE1, REGULATORSETTING0,
mc13892_vgen3),
MC13892_FIXED_DEFINE(VUSB, USB1, mc13892_vusb),
MC13892_GPO_DEFINE(GPO1, POWERMISC, mc13892_gpo),
@@ -476,8 +476,8 @@ static int mc13892_sw_regulator_set_voltage_sel(struct regulator_dev *rdev,
}
mc13xxx_lock(priv->mc13xxx);
- ret = mc13xxx_reg_rmw(priv->mc13xxx, mc13892_regulators[id].vsel_reg, mask,
- reg_value);
+ ret = mc13xxx_reg_rmw(priv->mc13xxx, mc13892_regulators[id].vsel_reg,
+ mask, reg_value);
mc13xxx_unlock(priv->mc13xxx);
return ret;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] regulator: twl: Fix checkpatch issue
2014-01-08 1:02 [PATCH 1/3] regulator: core: Fix checkpatch issue Jingoo Han
2014-01-08 1:03 ` [PATCH 2/3] regulator: mc13892: " Jingoo Han
@ 2014-01-08 1:04 ` Jingoo Han
2014-01-08 17:16 ` Mark Brown
2014-01-08 17:14 ` [PATCH 1/3] regulator: core: " Mark Brown
2 siblings, 1 reply; 7+ messages in thread
From: Jingoo Han @ 2014-01-08 1:04 UTC (permalink / raw
To: 'Mark Brown'
Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han',
'Balaji T K', 'Nishanth Menon'
Fix the following checkpatch warnings.
WARNING: please, no space before tabs
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Nishanth Menon <nm@ti.com>
---
drivers/regulator/twl-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
index 8ebd785..fed28ab 100644
--- a/drivers/regulator/twl-regulator.c
+++ b/drivers/regulator/twl-regulator.c
@@ -58,7 +58,7 @@ struct twlreg_info {
struct regulator_desc desc;
/* chip specific features */
- unsigned long features;
+ unsigned long features;
/*
* optional override functions for voltage set/get
@@ -1128,7 +1128,7 @@ static int twlreg_probe(struct platform_device *pdev)
if (!initdata)
return -EINVAL;
- info = kmemdup(template, sizeof (*info), GFP_KERNEL);
+ info = kmemdup(template, sizeof(*info), GFP_KERNEL);
if (!info)
return -ENOMEM;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] regulator: core: Fix checkpatch issue
2014-01-08 1:02 [PATCH 1/3] regulator: core: Fix checkpatch issue Jingoo Han
2014-01-08 1:03 ` [PATCH 2/3] regulator: mc13892: " Jingoo Han
2014-01-08 1:04 ` [PATCH 3/3] regulator: twl: " Jingoo Han
@ 2014-01-08 17:14 ` Mark Brown
2 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2014-01-08 17:14 UTC (permalink / raw
To: Jingoo Han; +Cc: 'Liam Girdwood', linux-kernel
[-- Attachment #1: Type: text/plain, Size: 130 bytes --]
On Wed, Jan 08, 2014 at 10:02:16AM +0900, Jingoo Han wrote:
> Fix the following checkpatch errors and warnings.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] regulator: mc13892: Fix checkpatch issue
2014-01-08 1:03 ` [PATCH 2/3] regulator: mc13892: " Jingoo Han
@ 2014-01-08 17:15 ` Mark Brown
2014-01-09 0:35 ` Jingoo Han
0 siblings, 1 reply; 7+ messages in thread
From: Mark Brown @ 2014-01-08 17:15 UTC (permalink / raw
To: Jingoo Han; +Cc: 'Liam Girdwood', linux-kernel, 'Sascha Hauer'
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
On Wed, Jan 08, 2014 at 10:03:22AM +0900, Jingoo Han wrote:
> Fix the following checkpatch warnings.
>
> WARNING: Avoid unnecessary line continuations
> WARNING: line over 80 characters
This doesn't apply against current code, the same changes have already
been made by you in October.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] regulator: twl: Fix checkpatch issue
2014-01-08 1:04 ` [PATCH 3/3] regulator: twl: " Jingoo Han
@ 2014-01-08 17:16 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2014-01-08 17:16 UTC (permalink / raw
To: Jingoo Han
Cc: 'Liam Girdwood', linux-kernel, 'Balaji T K',
'Nishanth Menon'
[-- Attachment #1: Type: text/plain, Size: 248 bytes --]
On Wed, Jan 08, 2014 at 10:04:48AM +0900, Jingoo Han wrote:
> Fix the following checkpatch warnings.
>
> WARNING: please, no space before tabs
> WARNING: space prohibited between function name and open parenthesis '('
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] regulator: mc13892: Fix checkpatch issue
2014-01-08 17:15 ` Mark Brown
@ 2014-01-09 0:35 ` Jingoo Han
0 siblings, 0 replies; 7+ messages in thread
From: Jingoo Han @ 2014-01-09 0:35 UTC (permalink / raw
To: 'Mark Brown'
Cc: 'Liam Girdwood', linux-kernel, 'Sascha Hauer',
'Jingoo Han'
On Thursday, January 09, 2014 2:16 AM, Mark Brown wrote:
> On Wed, Jan 08, 2014 at 10:03:22AM +0900, Jingoo Han wrote:
> > Fix the following checkpatch warnings.
> >
> > WARNING: Avoid unnecessary line continuations
> > WARNING: line over 80 characters
>
> This doesn't apply against current code, the same changes have already
> been made by you in October.
Sorry for annoying you.
I checked this patch applied to 'mc13892' branch in regulator
git tree. Thank you. :-)
Happy New Year!
Best regards,
Jingoo Han
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-01-09 0:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-08 1:02 [PATCH 1/3] regulator: core: Fix checkpatch issue Jingoo Han
2014-01-08 1:03 ` [PATCH 2/3] regulator: mc13892: " Jingoo Han
2014-01-08 17:15 ` Mark Brown
2014-01-09 0:35 ` Jingoo Han
2014-01-08 1:04 ` [PATCH 3/3] regulator: twl: " Jingoo Han
2014-01-08 17:16 ` Mark Brown
2014-01-08 17:14 ` [PATCH 1/3] regulator: core: " Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.