From: Rafael J. Wysocki <rafael at kernel.org>
To: devel@acpica.org
Subject: [Devel] Re: [PATCH] tools: Delete the initialization value
Date: Thu, 25 Aug 2022 13:22:41 +0200 [thread overview]
Message-ID: <CAJZ5v0jVpCiwscgVQqS3yEwGaHUCPzR9pNDjt6qY6U4jJubt_A@mail.gmail.com> (raw)
In-Reply-To: 20220825090347.30555-1-junming@nfschina.com
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
On Thu, Aug 25, 2022 at 11:04 AM shijm <junming(a)nfschina.com> wrote:
>
> From: Shi junming <junming(a)nfschina.com>
>
> From the perspective of commpier,delete the initialization value
I'm not sure what this means.
The initialization is unnecessary, because the variable in question is
always assigned a new value before reading it. Is that what you
wanted to say?
> Signed-off-by: Shi junming <junming(a)nfschina.com>
> ---
> tools/power/acpi/tools/pfrut/pfrut.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/power/acpi/tools/pfrut/pfrut.c b/tools/power/acpi/tools/pfrut/pfrut.c
> index d79c335594b2..52aa0351533c 100644
> --- a/tools/power/acpi/tools/pfrut/pfrut.c
> +++ b/tools/power/acpi/tools/pfrut/pfrut.c
> @@ -190,7 +190,7 @@ int main(int argc, char *argv[])
> void *addr_map_capsule;
> struct stat st;
> char *log_buf;
> - int ret = 0;
> + int ret;
>
> if (getuid() != 0) {
> printf("Please run the tool as root - Exiting.\n");
> --
> 2.18.2
>
next reply other threads:[~2022-08-25 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 11:22 Rafael J. Wysocki [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-03 18:37 [Devel] Re: [PATCH] tools: Delete the initialization value Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0jVpCiwscgVQqS3yEwGaHUCPzR9pNDjt6qY6U4jJubt_A@mail.gmail.com \
--to=devel@acpica.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).