From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Yuntao Wang <ytcoode@gmail.com>
Cc: Robert Moore <robert.moore@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPICA: Remove unused struct field and incorrect comments
Date: Wed, 6 Dec 2023 20:49:30 +0100 [thread overview]
Message-ID: <CAJZ5v0h-7mhSP5BAig6fj-pax6V_m=u2ygjYU4DxMypJfqv5Cg@mail.gmail.com> (raw)
In-Reply-To: <20231127055858.41004-1-ytcoode@gmail.com>
On Mon, Nov 27, 2023 at 6:59 AM Yuntao Wang <ytcoode@gmail.com> wrote:
>
> The return_object_type field in `struct acpi_evaluate_info` is unused,
> so remove it.
>
> There are also some issues in the comments of acpi_ps_execute_method().
> First, the parameter_type field has already been removed from
> `struct acpi_evaluate_info`, so the corresponding field description in
> the comments should also be removed. Second, the return_object field
> description in the comments is duplicated. Remove these incorrect comments.
>
> Signed-off-by: Yuntao Wang <ytcoode@gmail.com>
> ---
> drivers/acpi/acpica/acstruct.h | 1 -
> drivers/acpi/acpica/psxface.c | 3 ---
> 2 files changed, 4 deletions(-)
This is ACPICA code which comes from a separate project.
The way to change it is to submit a pull request with the desired change
to the upstream ACPICA project on GitHub and add a Link tag pointing
to the upstream PR to the corresponding Linux patch. Then, the Linux
patch can only be applied after the corresponding upstream PR has been
merged.
Thanks!
> diff --git a/drivers/acpi/acpica/acstruct.h b/drivers/acpi/acpica/acstruct.h
> index f8fee94ba708..fe57c3a16e59 100644
> --- a/drivers/acpi/acpica/acstruct.h
> +++ b/drivers/acpi/acpica/acstruct.h
> @@ -169,7 +169,6 @@ struct acpi_evaluate_info {
> u16 param_count; /* Count of the input argument list */
> u16 node_flags; /* Same as Node->Flags */
> u8 pass_number; /* Parser pass number */
> - u8 return_object_type; /* Object type of the returned object */
> u8 flags; /* General flags */
> };
>
> diff --git a/drivers/acpi/acpica/psxface.c b/drivers/acpi/acpica/psxface.c
> index 6f4eace0ba69..df5679bbc510 100644
> --- a/drivers/acpi/acpica/psxface.c
> +++ b/drivers/acpi/acpica/psxface.c
> @@ -70,9 +70,6 @@ acpi_debug_trace(const char *name, u32 debug_level, u32 debug_layer, u32 flags)
> * NULL if no parameters are being passed.
> * return_object - Where to put method's return value (if
> * any). If NULL, no value is returned.
> - * parameter_type - Type of Parameter list
> - * return_object - Where to put method's return value (if
> - * any). If NULL, no value is returned.
> * pass_number - Parse or execute pass
> *
> * RETURN: Status
> --
> 2.43.0
>
>
prev parent reply other threads:[~2023-12-06 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 5:58 [PATCH] ACPICA: Remove unused struct field and incorrect comments Yuntao Wang
2023-12-06 19:49 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0h-7mhSP5BAig6fj-pax6V_m=u2ygjYU4DxMypJfqv5Cg@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=acpica-devel@lists.linux.dev \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=ytcoode@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).