From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Robert Moore <robert.moore@intel.com>,
linux-acpi@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
Len Brown <lenb@kernel.org>
Subject: Re: [Acpica-devel] [PATCH] ACPICA: Slightly simplify an error message in acpi_ds_result_push()
Date: Mon, 29 May 2023 16:13:25 +0200 [thread overview]
Message-ID: <CAJZ5v0g2=iYThmRzJXofUXSMrVPM-T2Ck8-HxiS=2_cn3Hv52g@mail.gmail.com> (raw)
In-Reply-To: <4464371bc72147e10a392a1873466c8df033039c.1685341309.git.christophe.jaillet@wanadoo.fr>
On Mon, May 29, 2023 at 8:31 AM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> 'object' is known to be NULL at this point. There is little value to log
> it twice in the error message.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
ACPICA changes require (at least) a pull request submitted to the
upstream ACPICA project on GitHub.
If you have submitted one, please resend the Linux patch with a Link
tag pointing to the corresponding upstream ACPICA pull request.
Thanks!
> ---
> drivers/acpi/acpica/dswstate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/acpica/dswstate.c b/drivers/acpi/acpica/dswstate.c
> index d3841ded3a81..75338a13c802 100644
> --- a/drivers/acpi/acpica/dswstate.c
> +++ b/drivers/acpi/acpica/dswstate.c
> @@ -146,8 +146,8 @@ acpi_ds_result_push(union acpi_operand_object *object,
>
> if (!object) {
> ACPI_ERROR((AE_INFO,
> - "Null Object! Obj=%p State=%p Num=%u",
> - object, walk_state, walk_state->result_count));
> + "Null Object! State=%p Num=%u",
> + walk_state, walk_state->result_count));
> return (AE_BAD_PARAMETER);
> }
>
> --
> 2.34.1
>
prev parent reply other threads:[~2023-05-29 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 6:22 [Acpica-devel] [PATCH] ACPICA: Slightly simplify an error message in acpi_ds_result_push() Christophe JAILLET
2023-05-29 14:13 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0g2=iYThmRzJXofUXSMrVPM-T2Ck8-HxiS=2_cn3Hv52g@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).