acpica-devel.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: mark.rutland@arm.com, len.brown@intel.com,
	linux-hwmon@vger.kernel.org, linux-gpio@vger.kernel.org,
	mallikarjunappa.sangannavar@intel.com, robert.moore@intel.com,
	bala.senthil@intel.com, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Jonathan.Cameron@huawei.com,
	acpica-devel@lists.linuxfoundation.org,
	andriy.shevchenko@linux.intel.com, will@kernel.org,
	linux@roeck-us.net
Subject: Re: [Acpica-devel] [PATCH v3 1/6] ACPI: utils: Introduce acpi_dev_uid_match() for matching _UID
Date: Tue, 24 Oct 2023 12:28:39 +0300	[thread overview]
Message-ID: <20231024092839.GE3208943@black.fi.intel.com> (raw)
In-Reply-To: <20231024062018.23839-2-raag.jadav@intel.com>

On Tue, Oct 24, 2023 at 11:50:13AM +0530, Raag Jadav wrote:
> +/**
> + * acpi_dev_uid_match - Match device by supplied UID
> + * @adev: ACPI device to match.
> + * @uid2: Unique ID of the device.
> + *
> + * Matches UID in @adev with given @uid2.
> + *
> + * Returns:
> + *  - %true if matches.
> + *  - %false otherwise.

Nit: these actually do not get formatted like above so you can just
write it as

Returns: %true in case UIDs match, %false otherwise.

If it is even needed, I think it is pretty obvious from the function
name what it returns.

  reply	other threads:[~2023-10-24  9:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24  6:20 [Acpica-devel] [PATCH v3 0/6] Refine _UID references across kernel Raag Jadav
2023-10-24  6:20 ` [Acpica-devel] [PATCH v3 1/6] ACPI: utils: Introduce acpi_dev_uid_match() for matching _UID Raag Jadav
2023-10-24  9:28   ` Mika Westerberg [this message]
2023-10-24 10:57     ` Andy Shevchenko
2023-10-24  6:20 ` [Acpica-devel] [PATCH v3 2/6] pinctrl: intel: use " Raag Jadav
2023-10-24  6:20 ` [Acpica-devel] [PATCH v3 3/6] ACPI: utils: " Raag Jadav
2023-10-24  6:20 ` [Acpica-devel] [PATCH v3 4/6] ACPI: x86: " Raag Jadav
2023-10-24  6:20 ` [Acpica-devel] [PATCH v3 5/6] hwmon: nct6775: use acpi_dev_hid_uid_match() for matching _HID and _UID Raag Jadav
2023-10-25 18:59   ` Guenter Roeck
2023-10-24  6:20 ` [Acpica-devel] [PATCH v3 6/6] perf: arm_cspmu: " Raag Jadav
2023-10-24  9:30 ` [Acpica-devel] [PATCH v3 0/6] Refine _UID references across kernel Mika Westerberg
2023-10-24 11:00   ` Andy Shevchenko
2023-10-24 19:51   ` Rafael J. Wysocki
2023-10-25  2:05     ` Guenter Roeck
2023-10-25 11:32       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231024092839.GE3208943@black.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=acpica-devel@lists.linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bala.senthil@intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mallikarjunappa.sangannavar@intel.com \
    --cc=mark.rutland@arm.com \
    --cc=raag.jadav@intel.com \
    --cc=robert.moore@intel.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).