From be14891fd17aa9c4c8e8b18c6c761c79cac99b05 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 6 Jan 2017 10:48:39 +0000 Subject: rg_state: fix no-op gain detection Seeing tiny (or zero) values for the "gain" effect is an eyesore in process table output, and a waste of CPU cycles in sox. So stop using the "gain" effect for imperceptible changes in volume. While we're at it, remove the pointless knobs for setting this, too. They were never documented and I doubt anybody would want to tweak them at runtime. --- test/test_rg_integration.rb | 2 +- test/test_rg_state.rb | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) (limited to 'test') diff --git a/test/test_rg_integration.rb b/test/test_rg_integration.rb index a932720..29dd29b 100644 --- a/test/test_rg_integration.rb +++ b/test/test_rg_integration.rb @@ -63,7 +63,7 @@ class TestRgIntegration < Testcase check_gain.call(%r{gain -3}, "album_gain") check_gain.call(%r{gain -2}, "track_gain") - check_gain.call(%r{gain 0\.0}, "album_peak") + check_gain.call(%r{gain 0\.}, "album_peak") check_gain.call(%r{gain 2\.5}, "track_peak") s.req_ok("rg preamp+=1") diff --git a/test/test_rg_state.rb b/test/test_rg_state.rb index 3a84216..59061a2 100644 --- a/test/test_rg_state.rb +++ b/test/test_rg_state.rb @@ -20,6 +20,12 @@ class TestRGState < Testcase assert_equal({"preamp" => 0.666}, rg.to_hsh) end + def test_rg_vol_norm + rg = DTAS::RGState.new + assert_nil rg.rg_vol_norm(0.999999999) + assert_match(%r{\Again 0.827}, rg.rg_vol_norm(0.9)) + end + def test_mode_set rg = DTAS::RGState.new orig = rg.mode -- cgit v1.2.3-24-ge0c7