From e97a5c2b9d26db2e1dda3422d39711a1801e34a3 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 25 May 2021 10:22:34 +0000 Subject: do not shell-quote filenames for environment This allows dtas-player to play files with wonky filenames when piping ffmpeg (or avconv) to sox. SoX-only code dtas-player paths are not affected since they don't require an extra Bourne shell. All of our internal shell pipelines quote "$INFILE", anyways, so there was never any need to escape for those. This may cause compatibility problems for splitfx users, but splitfx is probably too esoteric to have any users besides myself. And I expect anybody editing audio with dtas-splitfx to pick shell-friendly filenames. dtas-player is far more general, and likely to encounter shell-unfriendly filenames which require quoting. --- lib/dtas/source/sox.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/dtas/source/sox.rb') diff --git a/lib/dtas/source/sox.rb b/lib/dtas/source/sox.rb index d63f0df..3a7fe7d 100644 --- a/lib/dtas/source/sox.rb +++ b/lib/dtas/source/sox.rb @@ -113,7 +113,7 @@ class DTAS::Source::Sox # :nodoc: def src_spawn(player_format, rg_state, opts) raise "BUG: #{self.inspect}#src_spawn called twice" if @to_io e = @env.merge!(player_format.to_env) - e["INFILE"] = xs(@infile) + e["INFILE"] = @infile # make sure these are visible to the "current" command... e["TRIMFX"] = trimfx -- cgit v1.2.3-24-ge0c7