From 1b680f0b124c0fe7b2aae48543643090c967ad44 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 5 Oct 2013 22:20:00 +0000 Subject: player: add factor out redundant condition check The addition of a "need_to_queue" method should reduce the amount of cognitive overhead required to parse these conditions --- lib/dtas/player.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'lib/dtas/player.rb') diff --git a/lib/dtas/player.rb b/lib/dtas/player.rb index efefcbf..f94c575 100644 --- a/lib/dtas/player.rb +++ b/lib/dtas/player.rb @@ -165,9 +165,13 @@ class DTAS::Player # :nodoc: rv end + def need_to_queue + @current || @queue[0] || @paused + end + def enq_handler(io, msg) # check @queue[0] in case we have no sinks - if @current || @queue[0] || @paused + if need_to_queue @queue << msg else next_source(msg) @@ -177,7 +181,7 @@ class DTAS::Player # :nodoc: def do_enq_head(io, msg) # check @queue[0] in case we have no sinks - if @current || @queue[0] || @paused + if need_to_queue @queue.unshift(msg) else next_source(msg) -- cgit v1.2.3-24-ge0c7