Date | Commit message (Collapse) |
|
This fixes a bug introduced in 0.12.0 which only affects
non-sleepy_penguin users.
Fixes: d3cf61b05d95 ("switch to exception-free non-blocking I/O")
|
|
Newer avprobe outputs a new format, fix our parser to workaround
this while remaining compatible with the old one in Debian wheezy.
Additionally, ffprobe is no longer available as a link to
avprobe.
|
|
When activated, this boolean deletes a song from the tracklist
after it is played.
|
|
.each on a Sequel dataset is more appropriate for the way we
emit comments.
And using Array#map! is more efficient when we do not
need the original array.
|
|
We will allow forcing updates since upgrading dependent software
(e.g. sox, avprobe, ffprobe) may allow previously-ignored files
to become support
|
|
Almost, we will need to get a list of all suffixes supported
by ffprobe or avprobe. This could prove tricky..
|
|
The @last_failed state is in the parent object, not the dup-ed
object we fork off of.
|
|
We load them frequently enough that the garbage
is not worth it.
|
|
This reduces memory usage as a Regexp object is hundreds
of bytes and a single-byte string object is only 40 bytes
that is deduped within the VM.
|
|
Hash#keys already allocates a new array, so we may sort it
in place without worrying about side effects and avoiding
an extra allocation.
|
|
We need to ensure children and comments are all deleted before
parents are.
|
|
For now, shuffle means "random without repeats". So avoid repeating
ourselves by shuffling when we've reached the end of the shuffled
tracklist and have no more tracks to go. Whenever a client restarts
the player or hits the loop for repeat, we'll have a freshly
shuffled list for them to listen to.
|
|
@pos is an array index, and should never go beyond
the last element.
|
|
We support this feature, so it should probably be shown along with
the repeat status of the tracklist. Ensure we notify all of our
listeners about the status change in player, too.
|
|
It is possible for a file to only have one of the ReplayGain
tags we need and not the previous-required REPLAYGAIN_TRACK_GAIN
tag. So do not reject the entire series of tags if a file has
the one we want.
|
|
Using the 'update-copyright' script from gnulib[1]:
git ls-files | UPDATE_COPYRIGHT_HOLDER='all contributors' \
UPDATE_COPYRIGHT_USE_INTERVALS=2 \
xargs /path/to/gnulib/build-aux/update-copyright
[1] git://git.savannah.gnu.org/gnulib.git
|
|
It's easier to leave numerics unquoted in YAML; so automatically
stringify comments comming from the YAML file.
|
|
For a music collection (even a large one), SQLite is sufficient
and less overhead than all of Sequel.
|
|
It probably makes sense for the -console user to know if tracklist
repeat and trim are enabled. Have player emit these in "current"
output and let the console client track them for now.
|
|
When invoking the "current" command, the player now returns the
first track + offset in the queue.
This should make it easier to show what's paused or not.
|
|
Oops :x
|
|
This only affected splitfx when it used the command option,
and only when calling dtas-splitfx (not when playing splitfx
files through the player).
|
|
We removed support for opusenc back in May as it was not
really suitable for audio production and a maintenance burden.
ref: commit 7ca5d0bfc714c254c374af9cbc2e024a8b439725
("splitfx: remove support for encoding opus")
|
|
While we're in the area, make a wording change from "GPLv3 or later"
to "GPL-3.0+", as the latter is favored by SPDX.org
|
|
We cannot use "dirname" in queries, oops :x
|
|
Not in any way a stable interface, yet, and still incomplete. This
should emulate parts of the mpd protocol which should make it easier
to debug and develop.
|
|
DTAS does not expose any sort of public API for external users,
so it will not be documented using RDoc. Currently all of our
documentation is in plain-text or Markdown (only for manpages).
|
|
Oops, normalization is probably a forgotten feature...
|
|
This is on a linear scale from 0.0 (mute) to 1.0 (no change)
This is in the MPRIS spec and mpd as well (scaled to 0-100)
This changes dtas-console key bindings (0/9) slightly to match
mplayer more closely. ReplayGain preamp adjustment has moved from
'0'/'9' to '7'/'8' keys. The 'm' key also toggles mute state (the
pre-mute volume is stored in the dtas-console instance, not in
dtas-player itself).
|
|
This allows clients to quickly query tracklist
size/position/shuffle/random info.
|
|
This (from the point of the client) will atomically swap
two tracks. This should allow easily implementing of a
tracklist editor.
|
|
Oops...
|
|
This is a new feature in Ruby 2.3 which can reduce allocations
without adding ugly ".freeze" calls everywhere. This is a small
enough file that we shouldn't have to worry about inadvertant
breakage.
|
|
This avoids stalling when we have a gigantic tracklist.
|
|
It is orders of magnitude more efficient to implement this
in the player and very noticeable when using large playlists.
|
|
Do not batch processing of requests or buffered output.
We cannot have clients running "dtas-tl cat" or similar
to dump a gigantic playlist cause us to have gaps in our
playback.
Since we implemented a tunable tracklist limit, we can
also remove the hardcoded 100 element limit for buffered
messages while we're at it; now the tracklist limit affects
maximum memory use.
|
|
The caller should dictate how the output format goes,
not the library.
|
|
This allows fast-ish tag searching, but the internal API
is still subject to change to ease emulation of mpd.
|
|
We'll continue supporting Ruby 1.9.3 as long as Debian wheezy is
supported.
|
|
These are the same stats used by the mpd "stats" command.
|
|
Files in a music library may be deleted or renamed, so our
library should not persist old data.
Unfortunately this double-stats all files, but using a hash
for temporary storage could also bloat memory/disk usage and
probably isn't worth it at the moment.
|
|
Ruby 2.3 will have `exception: false' support in socket-related
classes. Additionally, 2.3 will implement the existing
IO#*_nonblock methods more efficiently than before by avoiding
the hash allocation necessary for keywords.
For users on older Rubies, we'll continue supporting them with
compatibility wrappers; even Ruby 1.9.3 users (for now).
|
|
Disabling shuffle should be idempotent.
|
|
It makes more sense to return the previous value
rather than the newly-set one, since the user presumably
knows what they're setting and might care about the
previous value.
|
|
The dpc_tl method was becoming too large, split it up into
sub-methods for easier readability. While we're at it,
at least make "tl repeat" consistent with "tl shuffle"
when setting new values.
|
|
This defaults to 16384? This is what mpd uses by default as well.
Of course folks interacting with dtas-player directly can override
this:
dtas-tl max INTEGER
dtas-tl max
This is NOT meant to be a hard security measure for local users
talking to dtas-player directly. It is only to prevent
accidentally stupid things like flooding the playlist with
a broken script and to prevent remote users from DoS-ing
us via the to-be-written mpd proxy/emulation layer.
Remember: dtas-player itself will ALWAYS remain capable of
executing arbitrary code :)
|
|
This is in the MPRIS 2.0 TrackList spec and also in mpd (as "repeat"
mode), so we can probably support it directly in player to ease
implementations of future wrappers.
|
|
Building this hash is a linear operation anyways,
so there's no point in doing it when Array#index can stop
early if the track is found, to avoid unnecessary work.
|
|
This happens when "dtas-ctl state dump" is invoked manually;
causing "dtas-tl cat" to break afterwards.
Fixes: commit 7b065706d37df9e54c8b3299ce696545c6159fa4
("tracklist: use lower number unique track IDs")
|
|
This is easier for users to read and type; and _might_ help with
race conditions due to fast object recycling from GC. We'll also be
implementing playist versioning on top of this in the next commits
for MPD protocol compatibility.
Unfortunately this adds an additional 40 bytes of per-track overhead
(on 64-bit systems, its only 20 bytes on 32-bit). However, we may
be able to save memory in the future by supporting dtas-mlib node
IDs if we integrate dtas-player with DTAS::Mlib.
While we're at it, include a minor speedup for
DTAS::Tracklist#remove_track by using Array#delete_at instead of
relying on Array#compact! after assignment
This should improve "dtas-tl cat" output readability dramatically.
The state file (~/.dtas/player_state.yml) remains compatible
between dtas-player before and after this change.
|