Date | Commit message (Collapse) |
|
It happens with some video files, apparently.
|
|
The SQLite busy waiting scheme isn't great for usability
and the busy timeout is done by sleep+backoff. I prefer
to say we only support filesystems with flock() for our
little DB.
|
|
Redundant since ("player: support guessing encodings for comments")
|
|
Apparently some degree of thread-safety is being enforced;
not sure I agree, but oh well...
|
|
Oops, a Perlism crept in :x
|
|
This can be helpful for end users and is close to what other
players use. We can fallback to Encoding.default_external by
default (typically UTF-8) and then again using `charlock_holmes'
if installed.
Note: path names remain binary, because that's how proper
filesystems operate.
|
|
This should allow us easily to manipulate process pipelines
as an array of arrays.
Originally posted at
http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-talk/435624
|
|
This is faster than relying on eval() for older Rubies.
https://bugs.ruby-lang.org/issues/13077
Ruby 2.5 is targetted for release in December 2017.
|
|
This is needed for the "ALBUM ARTIST" tag which has a space in
the name. This is looser than
<http://www.xiph.org/vorbis/doc/v-comment.html>, but probably
good enough for practical purposes.
|
|
Seeing tiny (or zero) values for the "gain" effect is an eyesore
in process table output, and a waste of CPU cycles in sox. So
stop using the "gain" effect for imperceptible changes in volume.
While we're at it, remove the pointless knobs for setting this,
too. They were never documented and I doubt anybody would want
to tweak them at runtime.
|
|
We do not need it at runtime, only for testing on Linux-like
systems
|
|
One normal method dispatch is probably preferable to two
optimized instructions + immediate.
|
|
Ruby Hashes will automatically create frozen copies of unfrozen
strings used as hash keys to avoid accidental mutation.
Pre-freeze keys explicitly so the Ruby VM will not need to
create the frozen copy.
|
|
HTTPS allows some level of security(*) and we've actually
supported it on 80x24.org for many months, now. So, point new
readers to it.
Moving away from hostname-based homepages will allow us to save
on subjectAltName space (and bandwith) when negotiating an HTTPS
connection. We'll also have an .onion mirror for Tor users,
soon, too; in case we can't afford to pay ICANN in the future.
(assuming TLS libraries don't have any more Heartblead-level
bugs in them, CAs aren't compromised, MITM HTTPS stripping
proxies don't get in your way, and your certificate bundle isn't
compromised).
|
|
This should improve performance with slow filesystems
or systems with slow spawn performance.
|
|
We often waste cycles rerunning commands we don't need
to run frequently. Introduce a short term cache for
these.
|
|
Spawning processes under Ruby on Linux is relatively cheap,
but may not be for other OSes and it's still cheaper to
spawn fewer processes.
|
|
No reason to generate the command in a different place than
fade_out.
|
|
This ought to avoid busy DB errors.
|
|
These commands allow easier jumping within a track marked by
embedded CUE sheets. I've found them helpful for tracking out
large recordings of multiple tracks (e.g. vinyl transfers or
live concert recordings).
|
|
Seeking around a track should not be done relative to
a previous seek, but should rather be analogous to the
"tl prev" command to skip around the tracklist.
I'm not sure what drugs I was on when I originally wrote
this original version, but I'm fairly certain this is a
bugfix and not intentional behavior.
|
|
This fixes a bug introduced in 0.12.0 which only affects
non-sleepy_penguin users.
Fixes: d3cf61b05d95 ("switch to exception-free non-blocking I/O")
|
|
Newer avprobe outputs a new format, fix our parser to workaround
this while remaining compatible with the old one in Debian wheezy.
Additionally, ffprobe is no longer available as a link to
avprobe.
|
|
When activated, this boolean deletes a song from the tracklist
after it is played.
|
|
.each on a Sequel dataset is more appropriate for the way we
emit comments.
And using Array#map! is more efficient when we do not
need the original array.
|
|
We will allow forcing updates since upgrading dependent software
(e.g. sox, avprobe, ffprobe) may allow previously-ignored files
to become support
|
|
Almost, we will need to get a list of all suffixes supported
by ffprobe or avprobe. This could prove tricky..
|
|
The @last_failed state is in the parent object, not the dup-ed
object we fork off of.
|
|
We load them frequently enough that the garbage
is not worth it.
|
|
This reduces memory usage as a Regexp object is hundreds
of bytes and a single-byte string object is only 40 bytes
that is deduped within the VM.
|
|
Hash#keys already allocates a new array, so we may sort it
in place without worrying about side effects and avoiding
an extra allocation.
|
|
We need to ensure children and comments are all deleted before
parents are.
|
|
For now, shuffle means "random without repeats". So avoid repeating
ourselves by shuffling when we've reached the end of the shuffled
tracklist and have no more tracks to go. Whenever a client restarts
the player or hits the loop for repeat, we'll have a freshly
shuffled list for them to listen to.
|
|
@pos is an array index, and should never go beyond
the last element.
|
|
We support this feature, so it should probably be shown along with
the repeat status of the tracklist. Ensure we notify all of our
listeners about the status change in player, too.
|
|
It is possible for a file to only have one of the ReplayGain
tags we need and not the previous-required REPLAYGAIN_TRACK_GAIN
tag. So do not reject the entire series of tags if a file has
the one we want.
|
|
Using the 'update-copyright' script from gnulib[1]:
git ls-files | UPDATE_COPYRIGHT_HOLDER='all contributors' \
UPDATE_COPYRIGHT_USE_INTERVALS=2 \
xargs /path/to/gnulib/build-aux/update-copyright
[1] git://git.savannah.gnu.org/gnulib.git
|
|
It's easier to leave numerics unquoted in YAML; so automatically
stringify comments comming from the YAML file.
|
|
For a music collection (even a large one), SQLite is sufficient
and less overhead than all of Sequel.
|
|
It probably makes sense for the -console user to know if tracklist
repeat and trim are enabled. Have player emit these in "current"
output and let the console client track them for now.
|
|
When invoking the "current" command, the player now returns the
first track + offset in the queue.
This should make it easier to show what's paused or not.
|
|
Oops :x
|
|
This only affected splitfx when it used the command option,
and only when calling dtas-splitfx (not when playing splitfx
files through the player).
|
|
We removed support for opusenc back in May as it was not
really suitable for audio production and a maintenance burden.
ref: commit 7ca5d0bfc714c254c374af9cbc2e024a8b439725
("splitfx: remove support for encoding opus")
|
|
While we're in the area, make a wording change from "GPLv3 or later"
to "GPL-3.0+", as the latter is favored by SPDX.org
|
|
We cannot use "dirname" in queries, oops :x
|
|
Not in any way a stable interface, yet, and still incomplete. This
should emulate parts of the mpd protocol which should make it easier
to debug and develop.
|
|
DTAS does not expose any sort of public API for external users,
so it will not be documented using RDoc. Currently all of our
documentation is in plain-text or Markdown (only for manpages).
|
|
Oops, normalization is probably a forgotten feature...
|
|
This is on a linear scale from 0.0 (mute) to 1.0 (no change)
This is in the MPRIS spec and mpd as well (scaled to 0-100)
This changes dtas-console key bindings (0/9) slightly to match
mplayer more closely. ReplayGain preamp adjustment has moved from
'0'/'9' to '7'/'8' keys. The 'm' key also toggles mute state (the
pre-mute volume is stored in the dtas-console instance, not in
dtas-player itself).
|