about summary refs log tree commit homepage
path: root/lib
DateCommit message (Collapse)
2015-04-13escape INFILE and related environment variables
We may expand them, so ensure they're properly escaped, first for use in shell snippets.
2015-04-13xs: allow taking a string as input
This allows us to avoid unnecessary Array conversions in call sites
2015-02-13source/common: document dst_zero_byte attr
For seeking, the name might be a little confusing, but this is zero relative to the current queued source.
2015-02-04buffer: allow limiting the amount of bytes output tfx-pu
This will aid in allowing us to create effects which affect only a certain part of a track.
2015-02-04buffer/splice: prepare for IO::Splice::WAITALL removal
This feature in the io_splice was probably a bad idea and slated for removal at some point in the future. Anyways, do not rely on it since it is undocumented.
2015-02-04fadefx: effects chain generation
We need to generate a coherent command set for wrapping portions together, this sets us up for that.
2015-01-28player: fix queue skipping on player errors
Oops, introduced in the previous commit: commit 37eae22446feb5a805d9cd59f6ad54362829189f (player: support the "trim" parameter)
2015-01-28player: support the "trim" parameter
This feature is intended to allow users to "zoom-in" on a particular portion of a track to tweak parameters (either with dtas-sourceedit(1) or via playback of splitfx YAML files). This may be combined with looping the tracklist (via "tl repeat").
2015-01-25use omap (ordered map) for env hashes
While the Ruby Hash class is ordered in 1.9+, the YAML specifications do not specify hashes as ordered by default. Thus we must explicitly declare ordering via !omap for interopability with non-Ruby tools. This makes the YAML output of dtas-sourcedit and dtas-sinkedit slightly more verbose Users of dtas-splitfx are also encouraged to declare !omap when creating their YAML files for interoperability. Ordering env is important because any implementation of built-in variable expansion is dependent on it.
2015-01-23watchable: simplify check
@on_readable is always set, so there's no point in checking it again when we need to call it.
2015-01-20rename the TrimFX class to TFX
TrimFX was too ambiguous with the common environment variable we use throughout dtas. Since TFX is more limited in scope but should be more frequently-typed by users (of -splitfx) we'll use the shorter name here.
2015-01-20doc: describe most classes a bit
Hopefully this makes the code less daunting to newcomers
2015-01-20drop Rubinius workaround
I'm done with dealing with proprietary bug trackers.
2015-01-19update copyright years and links to mailing list archives
The documentation part is managed by the new Documentation/update-copyright script. For the future, the rest may be managed by the update-copyright tool in gnulib
2015-01-19Revert "fadefx: remove module"
This reverts commit 3471463325be6c990b3abd18b4d34f723440d19a. While not strictly necessary, it makes the user syntax in splitfx files much terser. Changes from the original version should make it easier-to-read and the diagram should help a lot with understanding.
2015-01-19consolidate spawn fix for Ruby [Bug #8770]
Ensure we can apply the workaround to dtas-sourceedit and our test cases while also simplifying the existing call sites a little. This will also make for less code churn in 3-5 years down the line when we drop <= 2.1 support.
2015-01-19avoid aliasing global "spawn" method
This makes debugging, grepping, and following code confusing at times and also unexpected breaks usage of the global "spawn" method.
2015-01-19splitfx: export TBEG and TLEN variables
These are the raw sample counts for the "trim" effect and may be useful for arithmetic in the shell.
2015-01-19sinkedit: flesh out all parameters
dtas-sinkedit now shows default parameters in addition to user-changed parameters, allowing easier editing. Also, we need to be able to revert back to using the default pipe_size on Linux by setting pipe_size to nil (as an empty field in YAML).
2015-01-19dtas-sourceedit: update player as user saves in the editor
This allows changes in the source YAML file to be reflected immediately in player after the user saves the file in their favorite $EDITOR. Previously, a user would need to: 1) start dtas-sourceedit, spawning $EDITOR 2) edit the file 3) save changes 4) exit $EDITOR 5) repeat starting from 1) until happy with the results Now, the workflow allows avoiding the context switch between their $EDITOR and terminal to restart dtas-sourcedit: 1) start dtas-sourceedit, spawning $EDITOR 2) edit the file 3) save changes 4) repeat starting from 1) until happy with the results 5) exit $EDITOR In my experience, this greatly speeds up tuning of the playback change, giving all the repeatability and flexibility of editing text files while having the immediacy of an interactive UI. Keep in mind this can cause problems for those with auto-save enabled in their $EDITOR buffer at inopportune times, so a -N/--no-watch option is added.
2015-01-19splitfx: remove unnecessary assignment
We already assigned fmt before entering the case statement, so make the case statement smaller.
2015-01-06player: enqueued commands cannot use bypass
We cannot specify an audio format for bypass mode, so inherit the last one we used and hope it works.
2015-01-03splitfx: remove redundant Hash#merge call
This was unnecessary since we already iterate through the overrides hash and merge "manually" based on command-line arguments (which allows us to represent nested hashes).
2015-01-03dtas-splitfx: use the top-level command used by -player
If somebody is using dtas-player to help edit a file for dtas-splitfx, it is likely they will want to use it when generating the final files (regardless of "target" format).
2015-01-03splitfx: add INDIR and INBASE environment variables
These are intended to act like `$(@D)' and `$(@F)' in GNU make(1) and to ease managing temporary files for some effects (e.g. noiseprof + noisered in sox) for splitfx users.
2014-12-29source/splitfx: fail gracefully on missing files
We cannot afford to break the entire player because somebody enqueued a non-existent file (or enqueued and later renamed it).
2014-12-29trimfx: require audio format at initialization
This makes things easier for scheduling/expansion since we won't have to deal with floating point numbers when we work directly with with sample counts (like the rest of dtas).
2014-12-29trimfx: comments and cleanups
It's been a while, and I've lost my train of thought regarding this system a bit :<
2014-12-28splitfx: use $FX env consistently in targets, too
While we're at it, document the splitfx manpage and make the example suitable for tests.
2014-12-28sigevent/efd: minor simplifications
This reduces memory overhead by a few bytes by eliminating constant lookups and unnecessary inclusions.
2014-12-28source/splitfx: default tracklist for single-track files
While the splitfx source is intended for applying effects to untracked audio files (e.g. transfers of vinyl records or live concert recordings), it should be useful for applying effects to an already-tracked recording.
2014-12-28source/splitfx: standardize on $FX for sox effects
This should allow users to setup effects in a more standardized fashion and avoid needing to specify a "command:" field in their splitfx YAML files in the general case.
2014-12-28source/splitfx: restart source on YAML modifications
Since splitfx YAML files are intended to be frequently edited and modified by the user, we'll support automatically restarting the source when the user saves changes via their favorite $EDITOR This change is only for Linux users. However, sleepy_penguin supports kqueue nowadays so a patch to support such functionality would be appreciated.
2014-12-27player: support "source restart" command
This becomes useful for systems without inotify when we're editing YAML (or whatever) files frequently and want changes to be reflected right away during playback. This is a weaker version of the plain "restart" command, which restarts the entire playback chain.
2014-12-27player: support playing splitfx YAML files
This allows splitfx users to test CUE breakpoints and run file-specific effects without interrupting their normal flow.
2014-12-24restart "source ed" after env changes
Merely converting the `before' source information to a hash is not enough, as the `env' sub-hash is mosified in-place and shared with the `after' hash. So use `inspect' to serialize and snapshot the env and rely on a string comparison.
2014-12-22reduce syscalls in recvmsg invocations
Favor IO.select over IO#wait since the latter makes another ioctl syscall (which we'll make anyways for IO#nread). Having BasicSocket#recvmsg and recvmsg_nonblock detect the buffer size requires extra syscalls, so pass explict maxmesglen, flags, and maxcontrollen args to elide auto-detection since we already have the buffered amount from IO#nread. This cuts more syscalls from the "dtas-tl cat" invocation with larger tracklists.
2014-12-08tracklist: favor &:sym_to_proc style
This is terser, reads better and generates smaller bytecode.
2014-12-08compat_onenine: simplify pipe wrapper
Array#each already returns the array, so there's no need to use the more confusing Array#map! block
2014-12-08process: update comment for bug workaround #2
Followup to commit 698e1f04580839ea29647f285b39b88fcbb46071 "process: update comment for bug workaround"
2014-12-08process: update comment for bug workaround
We're certain this is a workaround for a bug. We may remove the workaround at some point in the future; but not until the rest of the world has had a chance to upgrade, too.
2014-10-21unix_accepted: wait for readability on EAGAIN
We only drop dead connections, not live ones. This is noticeable on my home machine when using the "powersave" CPU governor.
2014-10-21favor &:proc form instead of blocks in more places
This generates smaller bytecode and avoids unnecessary captures. Perhaps the Ruby optimizer can be taught to handle this automatically.
2014-10-18sink: favor &:proc form instead of blocks
This generates smaller bytecode and avoids unnecessary captures.
2014-10-18unix_server: fix for infinite loop
Occasionally, killing a sink from an external process could result in an infinite loop due to the lack of close notification from __dst_error (in DTAS::Buffer) up to the top-level event loop. Since it is not easy to notify the top-level event loop, we'll detect closed IOs after-the-fact and retry as needed in a cold rescue path. This fixes an occasional error (usually when using a non-parallel make) in the test suite: TestPlayerIntegration#test_sink_killed_during_play: Timeout::Error: execution expired $HOME/dtas/test/player_integration.rb:57:in `sleep' $HOME/dtas/test/player_integration.rb:57:in `block in wait_pid_dead' $HOME/$RUBY/lib/ruby/2.2.0/timeout.rb:91:in `block in timeout' $HOME/$RUBY/lib/ruby/2.2.0/timeout.rb:35:in `block in catch' $HOME/$RUBY/lib/ruby/2.2.0/timeout.rb:35:in `catch' $HOME/$RUBY/lib/ruby/2.2.0/timeout.rb:35:in `catch' $HOME/$RUBY/lib/ruby/2.2.0/timeout.rb:106:in `timeout' $HOME/dtas/test/player_integration.rb:54:in `wait_pid_dead' test/test_player_integration.rb:42:in `test_sink_killed_during_play'
2014-08-26client_handler: minor cleanup (favor &:proc)
This reduces captures and is more consistent with our other code.
2014-08-16rely on filesystem encoding
This avoids compatibility problems as File.expand_path respects the "filesystem" encoding of Ruby. I'm not 100% sure this is correct, as Ruby encoding support still confuses me, but this fixes a problem where I attempted to add UTF-8 filename with non-US-ASCII characters in it on ruby-trunk.
2014-08-16xs: favor &: block style for simple cases
This avoids captures
2014-07-05fadefx: remove module
This will not be needed after all.
2014-06-30remove builtin-$FADEFX support
This is more generically supported via variables.