Date | Commit message (Collapse) |
|
These are the same stats used by the mpd "stats" command.
|
|
Files in a music library may be deleted or renamed, so our
library should not persist old data.
Unfortunately this double-stats all files, but using a hash
for temporary storage could also bloat memory/disk usage and
probably isn't worth it at the moment.
|
|
Ruby 2.3 will have `exception: false' support in socket-related
classes. Additionally, 2.3 will implement the existing
IO#*_nonblock methods more efficiently than before by avoiding
the hash allocation necessary for keywords.
For users on older Rubies, we'll continue supporting them with
compatibility wrappers; even Ruby 1.9.3 users (for now).
|
|
Disabling shuffle should be idempotent.
|
|
It makes more sense to return the previous value
rather than the newly-set one, since the user presumably
knows what they're setting and might care about the
previous value.
|
|
The dpc_tl method was becoming too large, split it up into
sub-methods for easier readability. While we're at it,
at least make "tl repeat" consistent with "tl shuffle"
when setting new values.
|
|
This defaults to 16384? This is what mpd uses by default as well.
Of course folks interacting with dtas-player directly can override
this:
dtas-tl max INTEGER
dtas-tl max
This is NOT meant to be a hard security measure for local users
talking to dtas-player directly. It is only to prevent
accidentally stupid things like flooding the playlist with
a broken script and to prevent remote users from DoS-ing
us via the to-be-written mpd proxy/emulation layer.
Remember: dtas-player itself will ALWAYS remain capable of
executing arbitrary code :)
|
|
This is in the MPRIS 2.0 TrackList spec and also in mpd (as "repeat"
mode), so we can probably support it directly in player to ease
implementations of future wrappers.
|
|
Building this hash is a linear operation anyways,
so there's no point in doing it when Array#index can stop
early if the track is found, to avoid unnecessary work.
|
|
This happens when "dtas-ctl state dump" is invoked manually;
causing "dtas-tl cat" to break afterwards.
Fixes: commit 7b065706d37df9e54c8b3299ce696545c6159fa4
("tracklist: use lower number unique track IDs")
|
|
This is easier for users to read and type; and _might_ help with
race conditions due to fast object recycling from GC. We'll also be
implementing playist versioning on top of this in the next commits
for MPD protocol compatibility.
Unfortunately this adds an additional 40 bytes of per-track overhead
(on 64-bit systems, its only 20 bytes on 32-bit). However, we may
be able to save memory in the future by supporting dtas-mlib node
IDs if we integrate dtas-player with DTAS::Mlib.
While we're at it, include a minor speedup for
DTAS::Tracklist#remove_track by using Array#delete_at instead of
relying on Array#compact! after assignment
This should improve "dtas-tl cat" output readability dramatically.
The state file (~/.dtas/player_state.yml) remains compatible
between dtas-player before and after this change.
|
|
Using an RFC-822-like format since YAML quoting rules aren't very
human-friendly, and we already prevent newlines from entering our
DB anyways.
|
|
Eventually this will support searching and be the basis
of an mpd-compatible proxy in front of dtas-player
|
|
We can generate many command calls easily and dynamically, so
avoid the code and cognitive overhead for the majority of commands.
|
|
This will dump the contents of the current queue, including
positional seeking information and commands. This is mainly
intended for debugging and tools which rely on dtas internals.
|
|
This allows us to avoid wasting time reopening the same
device over and over again.
|
|
Seems a bit stupid, but oh well.
|
|
This makes it easier to use in a user-friendly scripting interface
we have coming up.
|
|
We never use the full return value of the recvmsg* methods,
so those allocations are wasted.
|
|
Oops!
|
|
This allows splitfx YAML files to operate more seamlessly with
external commands such as play(1) especially when combined with
the -t/--trim option.
|
|
No point in executing echo and wasting CPU cycles. We'll only waste
cycles now during dry-runs
|
|
|
|
We no longer use it since
commit 7b47191aa4c88b3daa4c980013f0047cb7ae7f6d
("splitfx: avoid double-truncation with user command")
|
|
Since writing nested shell commands inside YAML is subject to all
sorts of strange quoting rules, encourage users to rely on external
scripts which the YAML file refers to instead. These scripts can be
written in any reasonable scripting language capable of executing
other commands.
This allows transparently monitoring things such as `my-script.rb'
in the below example when playing my-splitfx.yml via dtas-player:
--------------------- my-splitfx.yml -----------------------
infile: input.flac
command: $INDIR/my-script.rb "$INFILE"
...
--------------------- my-script.rb --------------------------
#!/usr/bin/ruby
require 'shellwords'
infile = ARGV.shift
ch = %W(sox #{infile} -p).concat((ENV['TRIMFX'] || '').shellsplit)
fx = %W(highpass 25 gain 9)
l = ch.dup.concat(%W(remix 1v1)).concat(fx).concat(%w(contrast 30))
r = ch.dup.concat(%W(remix 2v1)).concat(fx).concat(%w(contrast 0))
cmd = %W(sox -M |#{l.shelljoin} |#{r.shelljoin})
cmd.concat((ENV['SOXFMT'] || '-p').shellsplit)
cmd.concat(%w(- stats))
warn cmd.inspect
exec *cmd
|
|
It's probably harmless as the sub (second) command is usually
innocuous as fars a modifying dynamic range, but it makes the
command-line output confusing.
|
|
Lossy file encoding has too many tunable variables and it is not a
good fit for an audio production tool such as dtas-splitfx. This
was becoming a maintenance burden for me and is a sign of
featuritis.
|
|
Oops...
|
|
This can make it easier to specify mcompand parameters in
socks, as those require separate levels of parameter parsing
and require quoting in shell.
|
|
It can often be useful to expose only part of a track for quick
inspection. This lets us do that.
|
|
The monotonic clock is immune to stepping adjustments so it is
more suitable for tracking elapsed time differences.
Process.clock_gettime also generates less garbage on 64-bit systems
due to the use of Flonum.
|
|
Regression appeared in the previous commit, oops.
commit ab63c7bb1b69423f8c39a60dd00230c560eecfc4
(splitfx: fix lossy output with player command is in use)
|
|
We must ensure lossy encodings do not get lossily-encoded twice,
only once at the final stage. There is no effect for lossless
outputs as lossless is the common case for splitfx users.
|
|
generic targets (e.g. "wav") is useful for quickly checking if
clipping is introduced by dither and resampling, so we'll support
changing the sample rate and bits-per-sample from the command-line
so users don't need to setup their own targets or wait on FLAC
encoding.
|
|
This can be useful for speeding up splitfx during development,
as sox defaults to maximum compression with FLAC and that is
extremely slow.
|
|
It is useful to force output to a writable directory if the YAML
file is on a read-only mount point or to force the output to a
large tmpfs mount point to avoid SSD/HDD wear.
|
|
We do not need to dither unless we output to 16-bit or less.
This bug caused us to unnecessarily apply dither on 24-bit
output files. Oops!
|
|
If a file is missing, we must not respect the repeat option
set by the user to avoid infinite looping
|
|
The `gain' effect seems superior as it can "see" across the effects
chain to take into account extra/lost headroom.
For example, this allows me to add the the "gain -h" effect at the
start of my effects chain before the RGFX placeholder in my source
command, so when I play a file requiring a -6dB ReplayGain adjustment,
I will only need an additional -4dB of headroom to accomodate the
10dB boost at 20Hz I use (for listening through headphones):
Before:
RGFX='vol -6dB'
sox "$INFILE" $SOXFMT - $TRIMFX $RGFX vol -10dB equalizer 20 0.7071q 10
After:
RGFX='gain -6'
sox "$INFILE" $SOXFMT - $TRIMFX gain -h $RGFX equalizer 20 0.7071q 10
|
|
We already convert xs arg to be an Array, so avoid bloating
our code with redundancy.
|
|
We may expand them, so ensure they're properly escaped, first
for use in shell snippets.
|
|
This allows us to avoid unnecessary Array conversions in
call sites
|
|
For seeking, the name might be a little confusing,
but this is zero relative to the current queued source.
|
|
This will aid in allowing us to create effects which affect
only a certain part of a track.
|
|
This feature in the io_splice was probably a bad idea
and slated for removal at some point in the future.
Anyways, do not rely on it since it is undocumented.
|
|
We need to generate a coherent command set for wrapping
portions together, this sets us up for that.
|
|
Oops, introduced in the previous commit:
commit 37eae22446feb5a805d9cd59f6ad54362829189f
(player: support the "trim" parameter)
|
|
This feature is intended to allow users to "zoom-in" on a
particular portion of a track to tweak parameters (either
with dtas-sourceedit(1) or via playback of splitfx YAML files).
This may be combined with looping the tracklist
(via "tl repeat").
|
|
While the Ruby Hash class is ordered in 1.9+, the YAML
specifications do not specify hashes as ordered by default.
Thus we must explicitly declare ordering via !omap for
interopability with non-Ruby tools.
This makes the YAML output of dtas-sourcedit and dtas-sinkedit
slightly more verbose
Users of dtas-splitfx are also encouraged to declare !omap
when creating their YAML files for interoperability.
Ordering env is important because any implementation of
built-in variable expansion is dependent on it.
|
|
@on_readable is always set, so there's no point in checking it
again when we need to call it.
|