Date | Commit message (Collapse) |
|
Minor bugfixes, this allows users to setup targets easily
without introducing them to the ":" Rubyism for symbols.
Also, use "track_start" instead of "track_first" to match
the existing published examples for numbering the first
track.
While we're at it, detect the decoded sample precision
correctly for dither use.
|
|
Having it return nil in a noop function seems wrong.
We can't silently discard the value (unlike pipe_size=)
|
|
We do not need it anymore since we only write to the targets
returned by Sink#spawn.
|
|
This seems to be working out nicely. Having a basic integration
test should be enough to get us started for now.
|
|
This will allow users to more-easily edit configs and feel
like a real shell. We no longer mistakenly expand nil env
variables to "" anymore, either.
|
|
Rounding should be more accurate, even though my original awk
snippet truncated the output.
|
|
This is lacking tests and documentation, but it works from
a old trivial sample I had from a recording I previously
split using plain POSIX shell
splitfx is like make(1) for splitting and minor audio
editing. It also allows any number of effects.
|
|
Singleton methods tend to be bad like this.
TODO: write tests for this.
|
|
This allows users to display the current env value for introspection
|
|
This allows me to hit Ctrl-C on a dtas-player(1) process, wait on
termination of the player, and immediately restart it without
worrying about sink conflicts upon restart.
Before this change, sinks would continue running for a bit
(depending on buffer sizes).
|
|
stop_sinks is already defined, so avoid repeating this loop
|
|
This helps in case dtas-player is hit with SIGKILL or the system
crashes. This does not fsync(2) as that could introduce delays on
slow filesystems. Users should open the file manually and fsync
themselves if they need to.
|
|
Some containers (e.g. large VOBs) are not easily probed and require
additional options for avprobe/ffprobe to find audio streams. We do
this by looping and increasing the duration/size of the probe to
find new audio streams.
This seems to work reasonably well for some DVD rips I have until
seeking is required. This breaks if the seek point (including seeks
for source effects) exceeds the avprobe/ffprobe -analyzeduration.
Anyways, I recommend extracting the audio stream (without
transcoding) out of the VOB container as the best way to go.
Something like:
avconv -analyzeduration 2G -probesize 2G \
-i input.vob -vn -sn -c:a copy -map 0:$STREAM_NR output.ext
|
|
The whole dtas project is committed to giving as much rope as users
need!
|
|
This is reproducible on a video file with a mono audio stream
when attempting playback in stereo.
|
|
No need to add the vol effect if it's going to be a noop.
|
|
We don't need it since IO#read(bytes, buf) will convert to
ASCII-8BIT anyways. Everywhere else, we ensure path names are
already binary. We do this mainly at the client layer before using
Shellwords to escape the paths.
We also must be careful about parsing output from soxi/avprobe
which can show us metadata in whatever encoding is in the file.
We must still handle data from parsing command output as binary,
as the encoding of file metadata tends to vary.
This also should buy us Syck compatibility for Ruby 1.9.3 users
on Debian systems where Ruby 1.9.3 still uses Syck.
|
|
All files we distribute in the tarball need to have a
copyright/license specified for Savannah.
We don't need the example state file anymore.
|
|
It's possible to get zero samples when playing streams of
unknown length (e.g. over Icecast over HTTP)
|
|
I should really write a test case for this, maybe later.
|
|
No we do not want to confuse `ri' users with this.
|
|
We expose no public API, so avoid cluttering users disk space with
useless ri/rdoc and avoid cluttering the web with HTML nobody will
read.
|
|
@current is only set if is active with a pid, now, so all
of our checks for @current.pid are redundant and confusing.
|
|
This should hopefully prevent us from getting wedged
if we hit an error while preparing to spawn (or during spawn).
|
|
Showing the warning for the same file over and over again is
annoying when seeking a file handled by avconv/ffmpeg, so stop
doing it.
While we're at it, the error handling for __load_comments is totally
redundant (absent of race conditions if another process modifies the
file). However, if we do hit races, all the other soxi invocations
would be racy, too; but we really just shouldn't care about such
a corner case in here.
|
|
Since ffmpeg/ffprobe are wrappers around their libav-variants,
I haven't had the chance to actually test with "real" ffmpeg,
but the usage is probably similar enough to not matter.
|
|
soxi may not handle some files correctly and detect zero samples
without error-ing out. If sox can't detect the sample count
or the file is really empty, then there's no point trying futher
and we'll fall back to avconv.
|
|
Sometimes we'll enqueue the wrong file and avconv won't be able to
handle it.
|
|
This is for consistency with source handlers.
|
|
While we're at it, add a test for this functionality, too.
|
|
These two are similar enough that it's possible to share
some code between them and also increase user-friendliness
at the same time.
|
|
We should be fully-capable of managing any number of options
to try sources in.
|
|
This should better prepare us to make "source ed" into
"source <av|sox> ed" and set per-source priorities.
We also now treat @env consistently for all per-source commands
(such as soxi/avprobe) so we can be sure we're using the same
installation of sox or libav if using a non-standard PATH, or if we
want to set AV_LOG_FORCE_NOCOLOR
|
|
I forgot :err is already handled by Process.spawn, so split out
the functionality into err_str where we want to use it.
Also, add a :no_raise flag which will allow us to better handle
avprobe/soxi calls which can fail and avoid needless exceptions.
|
|
Shellwords.join is an identical method and there's no reason not to
use it.
|
|
This should allow us to more easily transfer user-configured
environment variables to helper tools (avprobe/soxi).
|
|
We do not need a respawn flag, since we already infer expected vs
unexpected sink death by checking the @targets array.
Additionally, next_source must always check @current before
calling, and not clobber the existing @current because that
would cause two source processes writing into the same pipe.
|
|
Regexps are hard to write sometimes :x
Anyways, we should support using floating-point internally
for users who prefer it.
|
|
We need to tell sox to use and resample to the _player_ format
instead of the source format. Otherwise 48000 Hz audio (common for
video?) sounds very slow when attempting to play back on the default
44100 Hz. It is also likely preferable to choose the audio stream
which matches the player channel count instead of letting sox
automatically invoke the remix effect.
Before this change, playing 6-channel, 48000 Hz source into a sink
expecting stereo, 44100 Hz is rather disturbing...
While we're at it, clarify the spawn code for the sox source, too.
We can drop the test_format_from_file test now, since
it's probably overkill at this point.
|
|
avconv is capable of outputting to the .sox format, greatly
simplifying our life as it enables us to easily apply sox
effects on a per-source file basis.
dtas-sourceedit and the "source" protocol commands will need
to change to support internal priorities (like sink).
|
|
We'll be supporting reading the format from avprobe and ffprobe,
so we should avoid tying ourselves to soxi
|
|
We should've done this at the start, but we didn't.
|
|
a sink can never have respawn set and not be active
|
|
Instead, we rely on closing the pipe (EOF or SIGPIPE) to
stop sources and sinks. This way we remove the possibility
of old and new processes operating on the same pipe and
causing strange audio overlaps.
|
|
It's too much work for me to attempt to wedge SOCK_DGRAM or
SOCK_STREAM support into this. SOCK_SEQPACKET is the best use of
_my_ time and I have limited patience for crippled OSes. Linux has
had this forever and FreeBSD 9 supports SOCK_SEQPACKET already, so
maybe this will be another way to nudge developers of other OSes
into supporting SOCK_SEQPACKET.
If somebody can provide clean patches to support SOCK_DGRAM or
SOCK_STREAM, I'll accept them.
|
|
We documented this behavior in dtas-player.txt but failed to
implement it. Now our behavior matches the documentation!
|
|
Rename COPYRIGHT -> COPYING, as that seems to be the more common
name for the GPLv3 license file. Kill all rdoc, since I don't
agree with HTML documentation and we do not expose any Ruby APIs.
|
|
It was never fully-realized and too crazy/complex to be worth it.
In case we ever need it in the future, git will remember it for us.
|
|
We maintain most everything else, so we should maintain this, too.
|
|
Some effects may be easier to save/store with relative directory
paths, so allow changing this at runtime.
|