Date | Commit message (Collapse) |
|
Using the 'update-copyright' script from gnulib[1]:
git ls-files | UPDATE_COPYRIGHT_HOLDER='all contributors' \
UPDATE_COPYRIGHT_USE_INTERVALS=2 \
xargs /path/to/gnulib/build-aux/update-copyright
[1] https://git.savannah.gnu.org/git/gnulib.git
|
|
HTTPS allows some level of security(*) and we've actually
supported it on 80x24.org for many months, now. So, point new
readers to it.
Moving away from hostname-based homepages will allow us to save
on subjectAltName space (and bandwith) when negotiating an HTTPS
connection. We'll also have an .onion mirror for Tor users,
soon, too; in case we can't afford to pay ICANN in the future.
(assuming TLS libraries don't have any more Heartblead-level
bugs in them, CAs aren't compromised, MITM HTTPS stripping
proxies don't get in your way, and your certificate bundle isn't
compromised).
|
|
When activated, this boolean deletes a song from the tracklist
after it is played.
|
|
For now, shuffle means "random without repeats". So avoid repeating
ourselves by shuffling when we've reached the end of the shuffled
tracklist and have no more tracks to go. Whenever a client restarts
the player or hits the loop for repeat, we'll have a freshly
shuffled list for them to listen to.
|
|
@pos is an array index, and should never go beyond
the last element.
|
|
Using the 'update-copyright' script from gnulib[1]:
git ls-files | UPDATE_COPYRIGHT_HOLDER='all contributors' \
UPDATE_COPYRIGHT_USE_INTERVALS=2 \
xargs /path/to/gnulib/build-aux/update-copyright
[1] git://git.savannah.gnu.org/gnulib.git
|
|
While we're in the area, make a wording change from "GPLv3 or later"
to "GPL-3.0+", as the latter is favored by SPDX.org
|
|
This allows clients to quickly query tracklist
size/position/shuffle/random info.
|
|
This (from the point of the client) will atomically swap
two tracks. This should allow easily implementing of a
tracklist editor.
|
|
It is orders of magnitude more efficient to implement this
in the player and very noticeable when using large playlists.
|
|
Disabling shuffle should be idempotent.
|
|
This defaults to 16384? This is what mpd uses by default as well.
Of course folks interacting with dtas-player directly can override
this:
dtas-tl max INTEGER
dtas-tl max
This is NOT meant to be a hard security measure for local users
talking to dtas-player directly. It is only to prevent
accidentally stupid things like flooding the playlist with
a broken script and to prevent remote users from DoS-ing
us via the to-be-written mpd proxy/emulation layer.
Remember: dtas-player itself will ALWAYS remain capable of
executing arbitrary code :)
|
|
This is in the MPRIS 2.0 TrackList spec and also in mpd (as "repeat"
mode), so we can probably support it directly in player to ease
implementations of future wrappers.
|
|
Building this hash is a linear operation anyways,
so there's no point in doing it when Array#index can stop
early if the track is found, to avoid unnecessary work.
|
|
This happens when "dtas-ctl state dump" is invoked manually;
causing "dtas-tl cat" to break afterwards.
Fixes: commit 7b065706d37df9e54c8b3299ce696545c6159fa4
("tracklist: use lower number unique track IDs")
|
|
This is easier for users to read and type; and _might_ help with
race conditions due to fast object recycling from GC. We'll also be
implementing playist versioning on top of this in the next commits
for MPD protocol compatibility.
Unfortunately this adds an additional 40 bytes of per-track overhead
(on 64-bit systems, its only 20 bytes on 32-bit). However, we may
be able to save memory in the future by supporting dtas-mlib node
IDs if we integrate dtas-player with DTAS::Mlib.
While we're at it, include a minor speedup for
DTAS::Tracklist#remove_track by using Array#delete_at instead of
relying on Array#compact! after assignment
This should improve "dtas-tl cat" output readability dramatically.
The state file (~/.dtas/player_state.yml) remains compatible
between dtas-player before and after this change.
|
|
If a file is missing, we must not respect the repeat option
set by the user to avoid infinite looping
|
|
Hopefully this makes the code less daunting to newcomers
|
|
The documentation part is managed by the new
Documentation/update-copyright script. For the future, the rest may
be managed by the update-copyright tool in gnulib
|
|
This is terser, reads better and generates smaller bytecode.
|
|
I'm still normal, and still trolling, but 80x24.org will be epic :)
|
|
Otherwise we end up going past the end of the list.
|
|
We don't want to repeat tracks if a track was added to a spot
before the current position on the tracklist.
|
|
We should not have the position point too far past the end of the
list. This allows playback to start when we do "tl add" on
an idle player after removing something from the tracklist.
|
|
We have no public Ruby API, only socket protocols and data formats.
|
|
Because sometimes a song is just stuck in our head.
Or MPRIS 2.0 wants us to implement it this way...
|
|
Non-repeating tracklists should stop playing when there's nothing
to go back to.
|
|
This should make implementing SetPosition in the MPRIS 2.0 spec
possible.
|
|
This means we can go back and forth in the tracklist like a normal
music player. This will allow an easier MPRIS 2.0 implementation.
|
|
This is a more accurate depiction of what happens,
and we'll implement "next" and "previous" commands in the future.
|
|
We should return to the starting position of the tracklist if we
are idle.
|
|
We need to preserve the go_to-specified position for next_track,
doing otherwise would cause us to always be off-by-one.
|
|
This allows easier scripting if we want to add a bunch of tracks
|
|
This should allow us to eventually implement a MPRIS 2.0-compliant
tracklist.
|