| Date | Commit message (Collapse) |
|---|
|
The "diff" function detection for C does not map well to
Ruby files, take advantage of gitattributes(5) to improve
method name detection in generated patches as well as
making "git diff -W" output more useful.
|
|
Ruby 2.3 will have `exception: false' support in socket-related
classes. Additionally, 2.3 will implement the existing
IO#*_nonblock methods more efficiently than before by avoiding
the hash allocation necessary for keywords.
For users on older Rubies, we'll continue supporting them with
compatibility wrappers; even Ruby 1.9.3 users (for now).
|
|
Disabling shuffle should be idempotent.
|
|
It makes more sense to return the previous value
rather than the newly-set one, since the user presumably
knows what they're setting and might care about the
previous value.
|
|
The dpc_tl method was becoming too large, split it up into
sub-methods for easier readability. While we're at it,
at least make "tl repeat" consistent with "tl shuffle"
when setting new values.
|
|
This defaults to 16384? This is what mpd uses by default as well.
Of course folks interacting with dtas-player directly can override
this:
dtas-tl max INTEGER
dtas-tl max
This is NOT meant to be a hard security measure for local users
talking to dtas-player directly. It is only to prevent
accidentally stupid things like flooding the playlist with
a broken script and to prevent remote users from DoS-ing
us via the to-be-written mpd proxy/emulation layer.
Remember: dtas-player itself will ALWAYS remain capable of
executing arbitrary code :)
|
|
This is in the MPRIS 2.0 TrackList spec and also in mpd (as "repeat"
mode), so we can probably support it directly in player to ease
implementations of future wrappers.
|
|
Building this hash is a linear operation anyways,
so there's no point in doing it when Array#index can stop
early if the track is found, to avoid unnecessary work.
|
|
This happens when "dtas-ctl state dump" is invoked manually;
causing "dtas-tl cat" to break afterwards.
Fixes: commit 7b065706d37df9e54c8b3299ce696545c6159fa4
("tracklist: use lower number unique track IDs")
|
|
This is easier for users to read and type; and _might_ help with
race conditions due to fast object recycling from GC. We'll also be
implementing playist versioning on top of this in the next commits
for MPD protocol compatibility.
Unfortunately this adds an additional 40 bytes of per-track overhead
(on 64-bit systems, its only 20 bytes on 32-bit). However, we may
be able to save memory in the future by supporting dtas-mlib node
IDs if we integrate dtas-player with DTAS::Mlib.
While we're at it, include a minor speedup for
DTAS::Tracklist#remove_track by using Array#delete_at instead of
relying on Array#compact! after assignment
This should improve "dtas-tl cat" output readability dramatically.
The state file (~/.dtas/player_state.yml) remains compatible
between dtas-player before and after this change.
|
|
Using an RFC-822-like format since YAML quoting rules aren't very
human-friendly, and we already prevent newlines from entering our
DB anyways.
|
|
Eventually this will support searching and be the basis
of an mpd-compatible proxy in front of dtas-player
|
|
Not everybody cares for manpages.
|
|
Older Rubygems (1.8.23 at least on Debian wheezy) tried to modify
the version string directly.
|
|
This can speed up archiving in some cases, as FLAC with
compression-level 8 may be excessively slow.
|
|
We can generate many command calls easily and dynamically, so
avoid the code and cognitive overhead for the majority of commands.
|
|
The Atom feed has existed for a while, but the NNTP server
is brand new (and potentially buggy: drop a plain-text mail
to meta@public-inbox.org if you notice bugs)
|
|
RubyGems still complains about the '+', but it is SPDX-compliant...
|
|
Oops, files in bin/ should be executable.
|
|
Temporary files may still have spaces or weird chars in them.
Just keep in mind we need to use $EDITOR/$VISUAL as-is since that
may contain additional command-line arguments, so we cannot pass
an array.
|
|
When a player is paused with nothing player, we will not waste CPU
time polling for the player to become available. It is wasteful
of processing power and battery life.
|
|
This is dependent on Linux /proc/ (the "pos: " field
of /proc/$PID/fdinfo/$FD to be exact).
This was written to avoid seek latencies on a remote FUSE
filesystem with occasional packet loss.
|
|
This will dump the contents of the current queue, including
positional seeking information and commands. This is mainly
intended for debugging and tools which rely on dtas internals.
|
|
This allows us to avoid wasting time reopening the same
device over and over again.
|
|
Seems a bit stupid, but oh well.
|
|
This makes it easier to use in a user-friendly scripting interface
we have coming up.
|
|
We never use the full return value of the recvmsg* methods,
so those allocations are wasted.
|
|
Oops!
|
|
We'll be using the rate for automatically calculating CDDA
alignment in the future.
|
|
This allows splitfx YAML files to operate more seamlessly with
external commands such as play(1) especially when combined with
the -t/--trim option.
|
|
Broken by commit c02f0b8182b35df1a318418bbd0036c00be93b5c
("source/splitfx: allow watching extra external scripts")
Oops
|
|
I nearly forgot about this myself
|
|
No point in executing echo and wasting CPU cycles. We'll only waste
cycles now during dry-runs
|
|
|
|
We no longer use it since
commit 7b47191aa4c88b3daa4c980013f0047cb7ae7f6d
("splitfx: avoid double-truncation with user command")
|
|
Since writing nested shell commands inside YAML is subject to all
sorts of strange quoting rules, encourage users to rely on external
scripts which the YAML file refers to instead. These scripts can be
written in any reasonable scripting language capable of executing
other commands.
This allows transparently monitoring things such as `my-script.rb'
in the below example when playing my-splitfx.yml via dtas-player:
--------------------- my-splitfx.yml -----------------------
infile: input.flac
command: $INDIR/my-script.rb "$INFILE"
...
--------------------- my-script.rb --------------------------
#!/usr/bin/ruby
require 'shellwords'
infile = ARGV.shift
ch = %W(sox #{infile} -p).concat((ENV['TRIMFX'] || '').shellsplit)
fx = %W(highpass 25 gain 9)
l = ch.dup.concat(%W(remix 1v1)).concat(fx).concat(%w(contrast 30))
r = ch.dup.concat(%W(remix 2v1)).concat(fx).concat(%w(contrast 0))
cmd = %W(sox -M |#{l.shelljoin} |#{r.shelljoin})
cmd.concat((ENV['SOXFMT'] || '-p').shellsplit)
cmd.concat(%w(- stats))
warn cmd.inspect
exec *cmd
|
|
It's probably harmless as the sub (second) command is usually
innocuous as fars a modifying dynamic range, but it makes the
command-line output confusing.
|
|
It can be useful to display time as absolute seconds to
ease arithmetic for tracking files.
|
|
Lossy file encoding has too many tunable variables and it is not a
good fit for an audio production tool such as dtas-splitfx. This
was becoming a maintenance burden for me and is a sign of
featuritis.
|
|
Oops...
|
|
This can make it easier to specify mcompand parameters in
socks, as those require separate levels of parameter parsing
and require quoting in shell.
|
|
It can often be useful to expose only part of a track for quick
inspection. This lets us do that.
|
|
Oops
|
|
The monotonic clock is immune to stepping adjustments so it is
more suitable for tracking elapsed time differences.
Process.clock_gettime also generates less garbage on 64-bit systems
due to the use of Flonum.
|
|
Regression appeared in the previous commit, oops.
commit ab63c7bb1b69423f8c39a60dd00230c560eecfc4
(splitfx: fix lossy output with player command is in use)
|
|
We must ensure lossy encodings do not get lossily-encoded twice,
only once at the final stage. There is no effect for lossless
outputs as lossless is the common case for splitfx users.
|
|
Oops
|
|
dtas-player:
There is one dtas-player bugfix to fix an infinite loop on missing
files when repeating a single track.
commit b6515b3a8abab6dcc56166da825e01e2c083bfc9
ReplayGain also uses the "gain" effect instead of "vol", allowing
compatibility with "gain -h" to provide extra headroom in user
effects.
commit 403ed90e2e7bed3e017938d76e17037b0d5059b6
dtas-splitfx:
Dither is no longer applied when outputting bit-depths above 16-bit.
The --bits/-b/--rate/-r/-C/--compression command-line flags are
passed to sox(1) for output and allow overriding any targets
specified in the output.
commit e6a2ff2a3984320b1b83f5051709880a8b9d3708
commit 03b1303b1c7511fdd1a6b2f63d7c509e822a6a38)
The -O/--outdir switch allows specifying a different output
directory, useful for splitting from read-only checkouts or
to a faster tmpfs filesystem to avoid SSD wear.
commit 619b08c9d4e43d94bac39cd395c1def6fa796f06
dtas-splitfx is still a work-in-progress and rapidly improving :)
|
|
generic targets (e.g. "wav") is useful for quickly checking if
clipping is introduced by dither and resampling, so we'll support
changing the sample rate and bits-per-sample from the command-line
so users don't need to setup their own targets or wait on FLAC
encoding.
|
|
This can be useful for speeding up splitfx during development,
as sox defaults to maximum compression with FLAC and that is
extremely slow.
|