Date | Commit message (Collapse) |
|
We must ensure lossy encodings do not get lossily-encoded twice,
only once at the final stage. There is no effect for lossless
outputs as lossless is the common case for splitfx users.
|
|
Oops
|
|
dtas-player:
There is one dtas-player bugfix to fix an infinite loop on missing
files when repeating a single track.
commit b6515b3a8abab6dcc56166da825e01e2c083bfc9
ReplayGain also uses the "gain" effect instead of "vol", allowing
compatibility with "gain -h" to provide extra headroom in user
effects.
commit 403ed90e2e7bed3e017938d76e17037b0d5059b6
dtas-splitfx:
Dither is no longer applied when outputting bit-depths above 16-bit.
The --bits/-b/--rate/-r/-C/--compression command-line flags are
passed to sox(1) for output and allow overriding any targets
specified in the output.
commit e6a2ff2a3984320b1b83f5051709880a8b9d3708
commit 03b1303b1c7511fdd1a6b2f63d7c509e822a6a38)
The -O/--outdir switch allows specifying a different output
directory, useful for splitting from read-only checkouts or
to a faster tmpfs filesystem to avoid SSD wear.
commit 619b08c9d4e43d94bac39cd395c1def6fa796f06
dtas-splitfx is still a work-in-progress and rapidly improving :)
|
|
generic targets (e.g. "wav") is useful for quickly checking if
clipping is introduced by dither and resampling, so we'll support
changing the sample rate and bits-per-sample from the command-line
so users don't need to setup their own targets or wait on FLAC
encoding.
|
|
This can be useful for speeding up splitfx during development,
as sox defaults to maximum compression with FLAC and that is
extremely slow.
|
|
Followup-to commit 403ed90e2e7bed3e017938d76e17037b0d5059b6
(replaygain uses the "gain" effect instead of "vol")
The `gain' effect seems superior as it can "see" across the effects
chain to take into account extra/lost headroom.
|
|
It is useful to force output to a writable directory if the YAML
file is on a read-only mount point or to force the output to a
large tmpfs mount point to avoid SSD/HDD wear.
|
|
We do not need to dither unless we output to 16-bit or less.
This bug caused us to unnecessarily apply dither on 24-bit
output files. Oops!
|
|
If a file is missing, we must not respect the repeat option
set by the user to avoid infinite looping
|
|
The `gain' effect seems superior as it can "see" across the effects
chain to take into account extra/lost headroom.
For example, this allows me to add the the "gain -h" effect at the
start of my effects chain before the RGFX placeholder in my source
command, so when I play a file requiring a -6dB ReplayGain adjustment,
I will only need an additional -4dB of headroom to accomodate the
10dB boost at 20Hz I use (for listening through headphones):
Before:
RGFX='vol -6dB'
sox "$INFILE" $SOXFMT - $TRIMFX $RGFX vol -10dB equalizer 20 0.7071q 10
After:
RGFX='gain -6'
sox "$INFILE" $SOXFMT - $TRIMFX gain -h $RGFX equalizer 20 0.7071q 10
|
|
Otherwise it's not very readable since our version numbers
are no longer lexographically sortable.
|
|
Bug fixes:
* Exported INFILE environment variable is always shell-escaped
This prevent screw-ups when users are using funky filenames.
* dtas-player: enqueued commands cannot use audio format bypass
(the audio format cannot be known ahead-of-time from raw commands)
* YAML omap (ordered map) is explicitly used for all env hashes for
user editing. Normal (unordered hashes) are still allowed if loading
existing files. This does not affect Ruby 1.9+ users, but allows
easier processing for users of other languages.
New features (all platforms):
* dtas-player now plays dtas-splitfx YAML files support cue sheet
emulation based on the track list. Under Linux[1], changes to
the YAML file are reflected in real-time as the file is edited
and saved in an $EDITOR. This feature is useful for dialing
in EQ, compressor, and limiter effects on tracks.
* dtas-player supports the "source restart" command for restarting
playback on modified files for systems without inotify support.
* dtas-splitfx now exports the INDIR and INBASE environment variables
which are intended to act like `$(@D)' and `$(@F)' in GNU make(1).
It should ease managing temporary files for some effects
(e.g. noiseprof + noisered in sox)
* dtas-console supports '!' and '@' hotkeys keys for moving within
files with embedded cue sheets.
* dtas-player supports the "trim" command to focus on a particular
portion of a track. It may be useful when combined with the existing
"tl repeat" command for dialing in audio editing parameters
(via a splitfx YAML file):
To continuously repeat a 5 second part of the current track starting
at 1 minute into the track:
dtas-ctl tl repeat 1 && dtas-ctl trim 1:00 5
Passing "off" as the parameter disables trim:
dtas-ctl trim off
* dtas-env(7) manpage added for common environment variables across
the suite
* dtas-sinkedit shows default parameters in addition to user-changed
parameters
New features (Linux-only)
* dtas-sourceedit and dtas-sinkedit support inotify[1] when editing
the YAML text file. This allows real-time updates on $EDITOR
file save as the user edits the parameters of the commands used
for decoding and playback.
* dtas-archive - paranoid archival script for copying and (re-reading)
files. This is useful when transferring files from removable devices
to computers without ECC memory (or any other bit errors in transport
before main memory is accessed). This requires Ruby 1.9.3 or later
(no 3rd-party RubyGems) on Linux for IO#advise support.
There are also many internal cleanups and more work-in-progress
for dtas-splitfx features.
[1] feature requires the sleepy_penguin RubyGem to be installed.
|
|
New features need to be documented.
|
|
We already convert xs arg to be an Array, so avoid bloating
our code with redundancy.
|
|
We may expand them, so ensure they're properly escaped, first
for use in shell snippets.
|
|
This allows us to avoid unnecessary Array conversions in
call sites
|
|
This is mainly for consistency in behavior with dtas-sourceedit.
Using dtas-sourcedit is still more common and recommended as it
is less likely to introduce audible gaps and pauses.
|
|
This archives audio files (typically .wav from a portable devices)
as FLAC and performs a best-effort verification the file was
transferred succesfully without bit errors by dropping kernel caches
and rechecking the result.
|
|
For seeking, the name might be a little confusing,
but this is zero relative to the current queued source.
|
|
This will aid in allowing us to create effects which affect
only a certain part of a track.
|
|
This feature in the io_splice was probably a bad idea
and slated for removal at some point in the future.
Anyways, do not rely on it since it is undocumented.
|
|
We need to generate a coherent command set for wrapping
portions together, this sets us up for that.
|
|
Oops, introduced in the previous commit:
commit 37eae22446feb5a805d9cd59f6ad54362829189f
(player: support the "trim" parameter)
|
|
This feature is intended to allow users to "zoom-in" on a
particular portion of a track to tweak parameters (either
with dtas-sourceedit(1) or via playback of splitfx YAML files).
This may be combined with looping the tracklist
(via "tl repeat").
|
|
While the Ruby Hash class is ordered in 1.9+, the YAML
specifications do not specify hashes as ordered by default.
Thus we must explicitly declare ordering via !omap for
interopability with non-Ruby tools.
This makes the YAML output of dtas-sourcedit and dtas-sinkedit
slightly more verbose
Users of dtas-splitfx are also encouraged to declare !omap
when creating their YAML files for interoperability.
Ordering env is important because any implementation of
built-in variable expansion is dependent on it.
|
|
@on_readable is always set, so there's no point in checking it
again when we need to call it.
|
|
Users may hit Ctrl-Z to stop their editor during editing
and trigger SICHLD, do not waitpid2 indefinitely in that
case. This prevents missed "source ed" calls for inotify
users.
|
|
TrimFX was too ambiguous with the common environment variable we
use throughout dtas. Since TFX is more limited in scope but
should be more frequently-typed by users (of -splitfx) we'll use
the shorter name here.
|
|
Hopefully this makes the code less daunting to newcomers
|
|
I'm done with dealing with proprietary bug trackers.
|
|
The documentation part is managed by the new
Documentation/update-copyright script. For the future, the rest may
be managed by the update-copyright tool in gnulib
|
|
This reverts commit 3471463325be6c990b3abd18b4d34f723440d19a.
While not strictly necessary, it makes the user syntax in splitfx
files much terser. Changes from the original version should make it
easier-to-read and the diagram should help a lot with understanding.
|
|
Ensure we can apply the workaround to dtas-sourceedit and our
test cases while also simplifying the existing call sites a
little. This will also make for less code churn in 3-5
years down the line when we drop <= 2.1 support.
|
|
This makes debugging, grepping, and following code confusing
at times and also unexpected breaks usage of the global "spawn"
method.
|
|
These are the raw sample counts for the "trim" effect
and may be useful for arithmetic in the shell.
|
|
This rounds out the documentation a bit and hopefully
introduces/encourages some commonality between the playback
and processing/production components of dtas.
Clarify some splitfx-related environment variables while
we're at it.
|
|
dtas-sinkedit now shows default parameters in addition
to user-changed parameters, allowing easier editing.
Also, we need to be able to revert back to using the default
pipe_size on Linux by setting pipe_size to nil (as an empty
field in YAML).
|
|
This allows changes in the source YAML file to be reflected
immediately in player after the user saves the file in their
favorite $EDITOR. Previously, a user would need to:
1) start dtas-sourceedit, spawning $EDITOR
2) edit the file
3) save changes
4) exit $EDITOR
5) repeat starting from 1) until happy with the results
Now, the workflow allows avoiding the context switch between their
$EDITOR and terminal to restart dtas-sourcedit:
1) start dtas-sourceedit, spawning $EDITOR
2) edit the file
3) save changes
4) repeat starting from 1) until happy with the results
5) exit $EDITOR
In my experience, this greatly speeds up tuning of the playback
change, giving all the repeatability and flexibility of editing text
files while having the immediacy of an interactive UI.
Keep in mind this can cause problems for those with auto-save
enabled in their $EDITOR buffer at inopportune times, so a
-N/--no-watch option is added.
|
|
Attempting to perform operations on a file which which cannot
handle it should not cause dtas-console to die with a backtrace
|
|
We already assigned fmt before entering the case statement,
so make the case statement smaller.
|
|
This will likely become more available and faster than GNU nproc(1)
over time.
|
|
We cannot specify an audio format for bypass mode,
so inherit the last one we used and hope it works.
|
|
This was unnecessary since we already iterate through the overrides
hash and merge "manually" based on command-line arguments
(which allows us to represent nested hashes).
|
|
If somebody is using dtas-player to help edit a file for
dtas-splitfx, it is likely they will want to use it when
generating the final files (regardless of "target" format).
|
|
These are intended to act like `$(@D)' and `$(@F)' in GNU make(1)
and to ease managing temporary files for some effects
(e.g. noiseprof + noisered in sox) for splitfx users.
|
|
We cannot afford to break the entire player because somebody
enqueued a non-existent file (or enqueued and later renamed it).
|
|
This makes things easier for scheduling/expansion since we
won't have to deal with floating point numbers when we work
directly with with sample counts (like the rest of dtas).
|
|
It's been a while, and I've lost my train of thought regarding
this system a bit :<
|
|
While we're at it, document the splitfx manpage and
make the example suitable for tests.
|
|
The "-l" and "-r" switches used by the sox ladspa effect
(for latency compensation and replicate, respectively)
are not available until sox v14.4.2, so avoid using it
since it can fail tests on common systems today.
|