Date | Commit message (Collapse) |
|
Ensure we can apply the workaround to dtas-sourceedit and our
test cases while also simplifying the existing call sites a
little. This will also make for less code churn in 3-5
years down the line when we drop <= 2.1 support.
|
|
This makes debugging, grepping, and following code confusing
at times and also unexpected breaks usage of the global "spawn"
method.
|
|
These are the raw sample counts for the "trim" effect
and may be useful for arithmetic in the shell.
|
|
This rounds out the documentation a bit and hopefully
introduces/encourages some commonality between the playback
and processing/production components of dtas.
Clarify some splitfx-related environment variables while
we're at it.
|
|
dtas-sinkedit now shows default parameters in addition
to user-changed parameters, allowing easier editing.
Also, we need to be able to revert back to using the default
pipe_size on Linux by setting pipe_size to nil (as an empty
field in YAML).
|
|
This allows changes in the source YAML file to be reflected
immediately in player after the user saves the file in their
favorite $EDITOR. Previously, a user would need to:
1) start dtas-sourceedit, spawning $EDITOR
2) edit the file
3) save changes
4) exit $EDITOR
5) repeat starting from 1) until happy with the results
Now, the workflow allows avoiding the context switch between their
$EDITOR and terminal to restart dtas-sourcedit:
1) start dtas-sourceedit, spawning $EDITOR
2) edit the file
3) save changes
4) repeat starting from 1) until happy with the results
5) exit $EDITOR
In my experience, this greatly speeds up tuning of the playback
change, giving all the repeatability and flexibility of editing text
files while having the immediacy of an interactive UI.
Keep in mind this can cause problems for those with auto-save
enabled in their $EDITOR buffer at inopportune times, so a
-N/--no-watch option is added.
|
|
Attempting to perform operations on a file which which cannot
handle it should not cause dtas-console to die with a backtrace
|
|
We already assigned fmt before entering the case statement,
so make the case statement smaller.
|
|
This will likely become more available and faster than GNU nproc(1)
over time.
|
|
We cannot specify an audio format for bypass mode,
so inherit the last one we used and hope it works.
|
|
This was unnecessary since we already iterate through the overrides
hash and merge "manually" based on command-line arguments
(which allows us to represent nested hashes).
|
|
If somebody is using dtas-player to help edit a file for
dtas-splitfx, it is likely they will want to use it when
generating the final files (regardless of "target" format).
|
|
These are intended to act like `$(@D)' and `$(@F)' in GNU make(1)
and to ease managing temporary files for some effects
(e.g. noiseprof + noisered in sox) for splitfx users.
|
|
We cannot afford to break the entire player because somebody
enqueued a non-existent file (or enqueued and later renamed it).
|
|
This makes things easier for scheduling/expansion since we
won't have to deal with floating point numbers when we work
directly with with sample counts (like the rest of dtas).
|
|
It's been a while, and I've lost my train of thought regarding
this system a bit :<
|
|
While we're at it, document the splitfx manpage and
make the example suitable for tests.
|
|
The "-l" and "-r" switches used by the sox ladspa effect
(for latency compensation and replicate, respectively)
are not available until sox v14.4.2, so avoid using it
since it can fail tests on common systems today.
|
|
This reduces memory overhead by a few bytes by eliminating
constant lookups and unnecessary inclusions.
|
|
While the splitfx source is intended for applying effects to
untracked audio files (e.g. transfers of vinyl records or
live concert recordings), it should be useful for applying
effects to an already-tracked recording.
|
|
This should allow users to setup effects in a more standardized
fashion and avoid needing to specify a "command:" field in their
splitfx YAML files in the general case.
|
|
Since splitfx YAML files are intended to be frequently edited and
modified by the user, we'll support automatically restarting the
source when the user saves changes via their favorite $EDITOR
This change is only for Linux users. However, sleepy_penguin
supports kqueue nowadays so a patch to support such functionality
would be appreciated.
|
|
This becomes useful for systems without inotify when we're editing
YAML (or whatever) files frequently and want changes to be reflected
right away during playback. This is a weaker version of the plain
"restart" command, which restarts the entire playback chain.
|
|
This allows splitfx users to test CUE breakpoints and run
file-specific effects without interrupting their normal flow.
|
|
The '!' and '@' keys are used in mplayer to skip chapters,
so perhaps this is a good analogy.
|
|
Process.spawn allows vfork() + execve() usage in Ruby 2.2.0 to
improve performance over normal fork() + execve().
|
|
Merely converting the `before' source information to a hash is not
enough, as the `env' sub-hash is mosified in-place and shared with
the `after' hash. So use `inspect' to serialize and snapshot the
env and rely on a string comparison.
|
|
The major new feature is '>' and '<' keys are now supported
in the dtas-console interface for dtas-player.
"dtas-tl cat" also received a minor speedup for big tracklists
via syscall reductions
shortlog of changes since 0.8.0:
process: update comment for bug workaround
process: update comment for bug workaround #2
compat_onenine: simplify pipe wrapper
tracklist: favor &:sym_to_proc style
dtas-console: '>' and '<' keys for tracklist next/prev
dtas-tl: halve write() syscalls when emitting tracklists
reduce syscalls in recvmsg invocations
doc: flesh out "tl" subcommand docs
The best is yet to come!
|
|
The following subcommands are now documented:
* current
* current-id
* next
* prev
|
|
Favor IO.select over IO#wait since the latter makes another
ioctl syscall (which we'll make anyways for IO#nread).
Having BasicSocket#recvmsg and recvmsg_nonblock detect the buffer
size requires extra syscalls, so pass explict maxmesglen, flags, and
maxcontrollen args to elide auto-detection since we already have the
buffered amount from IO#nread.
This cuts more syscalls from the "dtas-tl cat" invocation with
larger tracklists.
|
|
Notably, this speeds up "dtas-tl cat" output a little bit.
Hrm, Ruby really should be using writev here, we'll need to
investigate at a later date.
|
|
These key bindings are used in mplayer, too.
|
|
This is terser, reads better and generates smaller bytecode.
|
|
Array#each already returns the array, so there's no need to
use the more confusing Array#map! block
|
|
Followup to commit 698e1f04580839ea29647f285b39b88fcbb46071
"process: update comment for bug workaround"
|
|
We're certain this is a workaround for a bug. We may remove the
workaround at some point in the future; but not until the rest of
the world has had a chance to upgrade, too.
|
|
Several bugfixes for the dtas-player and playback-related
components. Audio-editing support is still being worked on.
See git repository for full details:
git clone git://80x24.org/dtas
Terminal-browser-friendly HTML mail archives are also up at:
http://80x24.org/dtas-all/
The mailing list for anything related to dtas remains at:
dtas-all@nongnu.org
The list is open to all without subscription (no HTML email).
dtas is for and by users who never want to deal with GUIs.
shortlog of changes since 0.7.0:
dtas-console: add note to install "curses" gem if missing
test/helper: compat w/ coverage in Feature #9508
player: style cleanup to favor &:methods
update copyrights and email address for 2014
trimfx: initial cut of scheduling + gap filling
test/helper: ancient minitest compatibility
test_splitfx: fix tests without opus{enc,dec}
remove builtin-$FADEFX support
fadefx: remove module
tests: hoist out pluck generation
xs: favor &: block style for simple cases
rely on filesystem encoding
client_handler: minor cleanup (favor &:proc)
doc: document "tl get"/"dtas-tl cat" escaping gotcha
dtas-console: force encoding for current locale
unix_server: fix for infinite loop
sink: favor &:proc form instead of blocks
favor &:proc form instead of blocks in more places
unix_accepted: wait for readability on EAGAIN
|
|
We only drop dead connections, not live ones. This is noticeable
on my home machine when using the "powersave" CPU governor.
|
|
This generates smaller bytecode and avoids unnecessary captures.
Perhaps the Ruby optimizer can be taught to handle this
automatically.
|
|
This generates smaller bytecode and avoids unnecessary captures.
|
|
Occasionally, killing a sink from an external process could result in an
infinite loop due to the lack of close notification from __dst_error (in
DTAS::Buffer) up to the top-level event loop. Since it is not easy to
notify the top-level event loop, we'll detect closed IOs after-the-fact
and retry as needed in a cold rescue path.
This fixes an occasional error (usually when using a non-parallel make)
in the test suite:
TestPlayerIntegration#test_sink_killed_during_play:
Timeout::Error: execution expired
$HOME/dtas/test/player_integration.rb:57:in `sleep'
$HOME/dtas/test/player_integration.rb:57:in `block in wait_pid_dead'
$HOME/$RUBY/lib/ruby/2.2.0/timeout.rb:91:in `block in timeout'
$HOME/$RUBY/lib/ruby/2.2.0/timeout.rb:35:in `block in catch'
$HOME/$RUBY/lib/ruby/2.2.0/timeout.rb:35:in `catch'
$HOME/$RUBY/lib/ruby/2.2.0/timeout.rb:35:in `catch'
$HOME/$RUBY/lib/ruby/2.2.0/timeout.rb:106:in `timeout'
$HOME/dtas/test/player_integration.rb:54:in `wait_pid_dead'
test/test_player_integration.rb:42:in `test_sink_killed_during_play'
|
|
This is the one place we display the filename for users,
so it should hopefully make it displayable. Users who
care about proper display should use a locale which matches
their music collection (or rename their music collection
to match).
|
|
We shell-escape filenames, so they may not show up properly
when shuttled across the wire.
|
|
This reduces captures and is more consistent with our other code.
|
|
This avoids compatibility problems as File.expand_path respects the
"filesystem" encoding of Ruby. I'm not 100% sure this is correct,
as Ruby encoding support still confuses me, but this fixes a problem
where I attempted to add UTF-8 filename with non-US-ASCII characters
in it on ruby-trunk.
|
|
This avoids captures
|
|
This allows the same sound to be reused in tests.
|
|
This will not be needed after all.
|
|
This is more generically supported via variables.
|
|
Just skip the test for now since systems without opusenc and opusdec
are becoming rarer.
|