| Date | Commit message (Collapse) |
|---|
|
This should allow convenient rearranging and deleting of tracks from
the tracklist from your favorite $EDITOR.
|
|
This allows clients to quickly query tracklist
size/position/shuffle/random info.
|
|
This (from the point of the client) will atomically swap
two tracks. This should allow easily implementing of a
tracklist editor.
|
|
Oops...
|
|
This is a new feature in Ruby 2.3 which can reduce allocations
without adding ugly ".freeze" calls everywhere. This is a small
enough file that we shouldn't have to worry about inadvertant
breakage.
|
|
This avoids stalling when we have a gigantic tracklist.
|
|
Fixes: commit d628e9bd3c5ef42e44c8e14f8eaf9a85dd541a4c
("player: reduce I/O priority of connected clients")
Oops :x
|
|
It is orders of magnitude more efficient to implement this
in the player and very noticeable when using large playlists.
|
|
This makes interrupting the potentially long output of
"dtas-mlib dump" less ugly. Perhaps it makes sense for our
other scripts to follow suit.
|
|
Do not batch processing of requests or buffered output.
We cannot have clients running "dtas-tl cat" or similar
to dump a gigantic playlist cause us to have gaps in our
playback.
Since we implemented a tunable tracklist limit, we can
also remove the hardcoded 100 element limit for buffered
messages while we're at it; now the tracklist limit affects
maximum memory use.
|
|
We need this script to work under Ruby 1.9.3 as well,
for the time being.
|
|
The caller should dictate how the output format goes,
not the library.
|
|
This allows fast-ish tag searching, but the internal API
is still subject to change to ease emulation of mpd.
|
|
We'll continue supporting Ruby 1.9.3 as long as Debian wheezy is
supported.
|
|
These are the same stats used by the mpd "stats" command.
|
|
Files in a music library may be deleted or renamed, so our
library should not persist old data.
Unfortunately this double-stats all files, but using a hash
for temporary storage could also bloat memory/disk usage and
probably isn't worth it at the moment.
|
|
The "diff" function detection for C does not map well to
Ruby files, take advantage of gitattributes(5) to improve
method name detection in generated patches as well as
making "git diff -W" output more useful.
|
|
Ruby 2.3 will have `exception: false' support in socket-related
classes. Additionally, 2.3 will implement the existing
IO#*_nonblock methods more efficiently than before by avoiding
the hash allocation necessary for keywords.
For users on older Rubies, we'll continue supporting them with
compatibility wrappers; even Ruby 1.9.3 users (for now).
|
|
Disabling shuffle should be idempotent.
|
|
It makes more sense to return the previous value
rather than the newly-set one, since the user presumably
knows what they're setting and might care about the
previous value.
|
|
The dpc_tl method was becoming too large, split it up into
sub-methods for easier readability. While we're at it,
at least make "tl repeat" consistent with "tl shuffle"
when setting new values.
|
|
This defaults to 16384? This is what mpd uses by default as well.
Of course folks interacting with dtas-player directly can override
this:
dtas-tl max INTEGER
dtas-tl max
This is NOT meant to be a hard security measure for local users
talking to dtas-player directly. It is only to prevent
accidentally stupid things like flooding the playlist with
a broken script and to prevent remote users from DoS-ing
us via the to-be-written mpd proxy/emulation layer.
Remember: dtas-player itself will ALWAYS remain capable of
executing arbitrary code :)
|
|
This is in the MPRIS 2.0 TrackList spec and also in mpd (as "repeat"
mode), so we can probably support it directly in player to ease
implementations of future wrappers.
|
|
Building this hash is a linear operation anyways,
so there's no point in doing it when Array#index can stop
early if the track is found, to avoid unnecessary work.
|
|
This happens when "dtas-ctl state dump" is invoked manually;
causing "dtas-tl cat" to break afterwards.
Fixes: commit 7b065706d37df9e54c8b3299ce696545c6159fa4
("tracklist: use lower number unique track IDs")
|
|
This is easier for users to read and type; and _might_ help with
race conditions due to fast object recycling from GC. We'll also be
implementing playist versioning on top of this in the next commits
for MPD protocol compatibility.
Unfortunately this adds an additional 40 bytes of per-track overhead
(on 64-bit systems, its only 20 bytes on 32-bit). However, we may
be able to save memory in the future by supporting dtas-mlib node
IDs if we integrate dtas-player with DTAS::Mlib.
While we're at it, include a minor speedup for
DTAS::Tracklist#remove_track by using Array#delete_at instead of
relying on Array#compact! after assignment
This should improve "dtas-tl cat" output readability dramatically.
The state file (~/.dtas/player_state.yml) remains compatible
between dtas-player before and after this change.
|
|
Using an RFC-822-like format since YAML quoting rules aren't very
human-friendly, and we already prevent newlines from entering our
DB anyways.
|
|
Eventually this will support searching and be the basis
of an mpd-compatible proxy in front of dtas-player
|
|
Not everybody cares for manpages.
|
|
Older Rubygems (1.8.23 at least on Debian wheezy) tried to modify
the version string directly.
|
|
This can speed up archiving in some cases, as FLAC with
compression-level 8 may be excessively slow.
|
|
We can generate many command calls easily and dynamically, so
avoid the code and cognitive overhead for the majority of commands.
|
|
The Atom feed has existed for a while, but the NNTP server
is brand new (and potentially buggy: drop a plain-text mail
to meta@public-inbox.org if you notice bugs)
|
|
RubyGems still complains about the '+', but it is SPDX-compliant...
|
|
Oops, files in bin/ should be executable.
|
|
Temporary files may still have spaces or weird chars in them.
Just keep in mind we need to use $EDITOR/$VISUAL as-is since that
may contain additional command-line arguments, so we cannot pass
an array.
|
|
When a player is paused with nothing player, we will not waste CPU
time polling for the player to become available. It is wasteful
of processing power and battery life.
|
|
This is dependent on Linux /proc/ (the "pos: " field
of /proc/$PID/fdinfo/$FD to be exact).
This was written to avoid seek latencies on a remote FUSE
filesystem with occasional packet loss.
|
|
This will dump the contents of the current queue, including
positional seeking information and commands. This is mainly
intended for debugging and tools which rely on dtas internals.
|
|
This allows us to avoid wasting time reopening the same
device over and over again.
|
|
Seems a bit stupid, but oh well.
|
|
This makes it easier to use in a user-friendly scripting interface
we have coming up.
|
|
We never use the full return value of the recvmsg* methods,
so those allocations are wasted.
|
|
Oops!
|
|
We'll be using the rate for automatically calculating CDDA
alignment in the future.
|
|
This allows splitfx YAML files to operate more seamlessly with
external commands such as play(1) especially when combined with
the -t/--trim option.
|
|
Broken by commit c02f0b8182b35df1a318418bbd0036c00be93b5c
("source/splitfx: allow watching extra external scripts")
Oops
|
|
I nearly forgot about this myself
|
|
No point in executing echo and wasting CPU cycles. We'll only waste
cycles now during dry-runs
|
|
|