diff options
author | Eric Wong <e@80x24.org> | 2016-01-24 09:27:58 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2016-01-24 09:27:58 +0000 |
commit | 3a76adf065889787a300f5001126f3ca83731e27 (patch) | |
tree | 1c7a2ed39c7d24cff140da2e23af7a720d26aae5 /lib | |
parent | a9fcfdb4ac43ccd625df1667611fa143f155dedc (diff) | |
download | dtas-3a76adf065889787a300f5001126f3ca83731e27.tar.gz |
Hash#keys already allocates a new array, so we may sort it in place without worrying about side effects and avoiding an extra allocation.
Diffstat (limited to 'lib')
-rw-r--r-- | lib/dtas/player.rb | 2 | ||||
-rw-r--r-- | lib/dtas/player/client_handler.rb | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/lib/dtas/player.rb b/lib/dtas/player.rb index 461fcdb..32052be 100644 --- a/lib/dtas/player.rb +++ b/lib/dtas/player.rb @@ -115,7 +115,7 @@ class DTAS::Player # :nodoc: unless @sinks.empty? sinks = rv["sinks"] = [] # sort sinks by name for human viewability - @sinks.keys.sort.each do |name| + @sinks.keys.sort!.each do |name| sinks << @sinks[name].to_hsh end end diff --git a/lib/dtas/player/client_handler.rb b/lib/dtas/player/client_handler.rb index a4308ff..7ce9839 100644 --- a/lib/dtas/player/client_handler.rb +++ b/lib/dtas/player/client_handler.rb @@ -122,7 +122,7 @@ module DTAS::Player::ClientHandler # :nodoc: name = msg[1] case msg[0] when "ls" - io.emit(xs(@sinks.keys.sort)) + io.emit(xs(@sinks.keys.sort!)) when "rm" sink = @sinks.delete(name) or return io.emit("ERR #{name} not found") drop_sink(sink) @@ -484,7 +484,7 @@ module DTAS::Player::ClientHandler # :nodoc: __current_requeue return io.emit("OK") when "ls" - s = map.keys.sort { |a,b| map[a].tryorder <=> map[b].tryorder } + s = map.keys.sort! { |a,b| map[a].tryorder <=> map[b].tryorder } return io.emit(s.join(' ')) end |