about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2015-12-26 02:57:36 +0000
committerEric Wong <e@80x24.org>2015-12-26 02:57:36 +0000
commit1306cf481cfa3e2452d33d848a363afa8f20c012 (patch)
tree880e08218ef238b2e2335d065a5ac302587ae3b2
parentfe5aad0bdfe8e12d4cf92f9555273276fddf1aae (diff)
downloaddtas-1306cf481cfa3e2452d33d848a363afa8f20c012.tar.gz
We removed support for opusenc back in May as it was not
really suitable for audio production and a maintenance burden.

ref: commit 7ca5d0bfc714c254c374af9cbc2e024a8b439725
("splitfx: remove support for encoding opus")
-rw-r--r--Documentation/dtas-splitfx.txt23
-rw-r--r--lib/dtas/format.rb11
2 files changed, 1 insertions, 33 deletions
diff --git a/Documentation/dtas-splitfx.txt b/Documentation/dtas-splitfx.txt
index 1bf7903..108c530 100644
--- a/Documentation/dtas-splitfx.txt
+++ b/Documentation/dtas-splitfx.txt
@@ -160,11 +160,6 @@ Additional targets supported by default.
 * flac-cdda - this encodes the audio to "flac" format while being
   easily decompressible to a format suitable for being burned to audio CD.
 
-* opusenc - encodes to 16-bit, 48000 Hz Opus format using opusenc(1).
-  This uses sox(1) to dither/resample/apply effects as necessary.
-  This target exists as sox (as of v14.4.1) does not currently have
-  native opus encoding support.
-
 Custom targets may easily be defined to apply effects and gain.  For
 example, the following "flac24" target raises the volume of the left
 channel by 9.5dB and the right one by 8.5dB to compensate for channel
@@ -183,22 +178,6 @@ imbalance in a live concert recording from the audience:
           bits: 24
           rate: 48000
 
-For reference, the "opusenc" default target is implemented as follows:
-
-    targets:
-      opusenc:
-        command: sox "$INFILE" $COMMENTS $OUTFMT -
-           $TRIMFX $RATEFX $DITHERFX | opusenc --music
-           --raw-bits $BITS_PER_SAMPLE
-           $OPUSENC_BITRATE --raw-rate $RATE --raw-chan $CHANNELS
-           --raw-endianness $ENDIAN_OPUSENC
-           $OPUSENC_COMMENTS - $OUTDIR$TRACKNUMBER.opus
-        format:
-          bits: 16
-          rate: 48000
-          type: s16
-          channels: 2
-
 # COPYRIGHT
 
 Copyright 2013-2015 all contributors <dtas-all@nongnu.org>.\
@@ -206,4 +185,4 @@ License: GPL-3.0+ <http://www.gnu.org/licenses/gpl-3.0.txt>
 
 # SEE ALSO
 
-sox(1), ecasound(1), flac(1), opusenc(1), dtas-player(1)
+sox(1), ecasound(1), flac(1), dtas-player(1)
diff --git a/lib/dtas/format.rb b/lib/dtas/format.rb
index ee456d1..0e1ba57 100644
--- a/lib/dtas/format.rb
+++ b/lib/dtas/format.rb
@@ -87,16 +87,6 @@ class DTAS::Format # :nodoc:
     end
   end
 
-  # returns 1 or 0 depending on endianess
-  def endian_opusenc
-    case e = @endian || NATIVE_ENDIAN
-    when "big" then "1"
-    when "little" then "0"
-    else
-      raise"unsupported endian=#{e}"
-    end
-  end
-
   def to_eca_arg
     %W(-f #{@type}_#{endian2},#@channels,#@rate)
   end
@@ -138,7 +128,6 @@ class DTAS::Format # :nodoc:
       "SOXFMT" => to_sox_arg.join(' '),
       "ECAFMT" => to_eca_arg.join(' '),
       "ENDIAN2" => endian2,
-      "ENDIAN_OPUSENC" => endian_opusenc,
     }
     begin # don't set these if we can't get them, SOX_FILETYPE may be enough
       rv["BITS_PER_SAMPLE"] = bits_per_sample.to_s