* [PATCH 4/5] dtas-console: avoid crashing on failed cue seeks
2015-01-17 11:49 5% [PATCH 0/5] misc updates, major sourceedit feature! Eric Wong
@ 2015-01-17 11:49 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2015-01-17 11:49 UTC (permalink / raw)
To: dtas-all; +Cc: e
Attempting to perform operations on a file which which cannot
handle it should not cause dtas-console to die with a backtrace
---
bin/dtas-console | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/bin/dtas-console b/bin/dtas-console
index ee0c126..2ed2f0b 100755
--- a/bin/dtas-console
+++ b/bin/dtas-console
@@ -104,6 +104,10 @@ def rg_string(rg, current)
rv
end
+def may_fail(res, events)
+ events << res if res != "OK"
+end
+
enc_locale = Encoding.find("locale")
$stdout.set_encoding(enc_locale)
enc_opts = { undef: :replace, invalid: :replace, replace: '?' }
@@ -202,8 +206,8 @@ begin
when "f" then c.req_ok("rg fallback_gain-=1")
when ">" then c.req_ok("tl next")
when "<" then c.req_ok("tl prev")
- when "!" then c.req_ok("cue prev")
- when "@" then c.req_ok("cue next")
+ when "!" then may_fail(c.req("cue prev"), events)
+ when "@" then may_fail(c.req("cue next"), events)
when " "
c.req("play_pause")
when "r" # cycle through replaygain modes
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/5] misc updates, major sourceedit feature!
@ 2015-01-17 11:49 5% Eric Wong
2015-01-17 11:49 7% ` [PATCH 4/5] dtas-console: avoid crashing on failed cue seeks Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2015-01-17 11:49 UTC (permalink / raw)
To: dtas-all; +Cc: e
The last sourceedit change is _really_ exciting to me!
(as is the splitfx playback support pushed out earlier).
The editing/post-production-oriented features of dtas are
really coming together and I think 0.10.0 will be a big
milestone for this project.
Eric Wong (5):
partstats: use Etc.nprocessors on Ruby 2.2+
splitfx: remove unnecessary assignment
player: enqueued commands cannot use bypass
dtas-console: avoid crashing on failed cue seeks
dtas-sourceedit: update player as user saves in the editor
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2015-01-17 11:49 5% [PATCH 0/5] misc updates, major sourceedit feature! Eric Wong
2015-01-17 11:49 7% ` [PATCH 4/5] dtas-console: avoid crashing on failed cue seeks Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/dtas.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).