From: Eric Wong <e@80x24.org>
To: dtas-all@nongnu.org
Subject: [PATCH] av_ff_common: set TRACKNUMBER comment from "track"
Date: Thu, 12 Oct 2023 09:22:47 +0000 [thread overview]
Message-ID: <20231012092247.3683475-1-e@80x24.org> (raw)
ffprobe aways says `track' instead of `TRACKNUMBER'; but
the rest of our code follows FLAC metadata conventions;
so use `TRACKNUMBER'.
(avprobe is untested since the libav project is dead)
---
lib/dtas/source/av_ff_common.rb | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/dtas/source/av_ff_common.rb b/lib/dtas/source/av_ff_common.rb
index 0c84b2f..3839272 100644
--- a/lib/dtas/source/av_ff_common.rb
+++ b/lib/dtas/source/av_ff_common.rb
@@ -144,6 +144,11 @@ def av_ff_ok?
comments[k] = -DTAS.try_enc(v, enc)
end
+ # ffprobe always uses "track", favor FLAC convention "TRACKNUMBER":
+ if @comments['TRACK'] && !@comments['TRACKNUMBER']
+ @comments['TRACKNUMBER'] = @comments.delete('TRACK')
+ end
+
! @astreams.compact.empty?
end
reply other threads:[~2023-10-12 9:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/dtas/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012092247.3683475-1-e@80x24.org \
--to=e@80x24.org \
--cc=dtas-all@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/dtas.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).