From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D41C21F545 for ; Mon, 3 Jul 2023 00:43:28 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=80x24.org header.i=@80x24.org header.a=rsa-sha256 header.s=selector1 header.b=SUU6X6iy; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qG7f5-0006Oz-4n; Sun, 02 Jul 2023 20:43:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qG7f3-0006Ok-A5 for dtas-all@nongnu.org; Sun, 02 Jul 2023 20:43:25 -0400 Received: from dcvr.yhbt.net ([173.255.242.215]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qG7f1-00061A-HG for dtas-all@nongnu.org; Sun, 02 Jul 2023 20:43:25 -0400 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 9C2A71F548 for ; Mon, 3 Jul 2023 00:43:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1688344989; bh=6N2hINjzT4+ZNpZlNUaswxLAp4Pp2IFhZawuFTbA+B4=; h=From:To:Subject:Date:From; b=SUU6X6iyrXalATegRqv9EqXvPxvRNmywP2CfwwZuVPSY28YWqdgA8YLmHzQJ1a4Iz 6OrFQhIwmrbb3rH/uCbQKuWQ6OFhcdcER9DiDE/M4bz1WvcWq6pBgA4f9Uz2Y0ra+O POPUR+dZ1Mp0zYubdEj9MwoD5bPUq8hxI13ELJ3Y= From: Eric Wong To: dtas-all@nongnu.org Subject: [PATCH] dtas-tl: reduce syscalls to speedup `reto' subcommand Date: Mon, 3 Jul 2023 00:43:09 +0000 Message-ID: <20230703004309.928292-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=173.255.242.215; envelope-from=e@80x24.org; helo=dcvr.yhbt.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: dtas-all@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: duct tape audio suite List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dtas-all-bounces+e=80x24.org@nongnu.org Sender: dtas-all-bounces+e=80x24.org@nongnu.org Syscalls and waiting for responses are expensive, so grab 128 track IDs at once like we do for other subcommands. --- bin/dtas-tl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bin/dtas-tl b/bin/dtas-tl index 7659570..45a18b5 100755 --- a/bin/dtas-tl +++ b/bin/dtas-tl @@ -175,10 +175,10 @@ def add_after(c, argv, last_id) time = ARGV[2] re = Regexp.quote(re) if fixed re = ignorecase ? %r{#{re}}i : %r{#{re}} - get_track_ids(c).each do |track_id| - res = c.req("tl get #{track_id}") - res.sub!(/\A1 \d+=/, '') - if re =~ res + each_track(c) do |line| + line.sub!(/\A(\d+)=/, '') + track_id = $1 + if re =~ line req = %W(tl goto #{track_id}) req << time if time res = c.req(req)