From: Eric Wong <e@80x24.org>
To: dtas-all@nongnu.org
Subject: [PATCH] dtas-tl edit: do not shell-escape text file
Date: Sun, 13 Nov 2022 21:23:50 +0000 [thread overview]
Message-ID: <20221113212350.26703-1-e@80x24.org> (raw)
There's no need to shell-escape the text file in most cases, so
make the display of non-ASCII characters more pleasant to users
with UTF-8-capable terminals and editors.
---
bin/dtas-tl | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/bin/dtas-tl b/bin/dtas-tl
index e58ee31..7659570 100755
--- a/bin/dtas-tl
+++ b/bin/dtas-tl
@@ -43,7 +43,8 @@ def do_edit(c)
track_id = $1.to_i
orig_idx[track_id] = orig.size
orig << track_id
- tmp.write("#{Shellwords.escape(line)} =#{track_id}\n")
+ line = Shellwords.escape(line) if line.include?("\n")
+ tmp.write("#{line} =#{track_id}\n")
end
tmp.flush
@@ -100,13 +101,8 @@ def do_edit(c)
non_existent = []
add.each do |path, after_id|
orig = path
- path = Shellwords.split(path)[0]
- path = File.expand_path(path)
- unless File.exist?(path)
- path = orig.dup
- path = Shellwords.split(path)[0]
- path = File.expand_path(path)
- end
+ path = File.expand_path(orig)
+ path = File.expand_path(Shellwords.split(path)[0]) unless File.exist?(path)
if File.exist?(path)
cmd = %W(tl add #{path})
reply other threads:[~2022-11-13 21:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/dtas/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221113212350.26703-1-e@80x24.org \
--to=e@80x24.org \
--cc=dtas-all@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/dtas.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).