everything related to duct tape audio suite (dtas)
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: James Rowe <jnrowe@gmail.com>
Cc: dtas-all@nongnu.org
Subject: Re: [PATCH 3/4] dtas-console: set X11 terminal title iff DISPLAY is set
Date: Tue, 11 Jan 2022 17:29:59 +0000	[thread overview]
Message-ID: <20220111172959.GA20949@dcvr> (raw)
In-Reply-To: <20220108165914.iukehydobheiii2k@gmail.com>

James Rowe <jnrowe@gmail.com> wrote:
> * Eric Wong (e@80x24.org) wrote:
> > +set_title = ENV['DISPLAY'] ? $stdout : nil
> 
>   Perhaps consider testing for $WAYLAND_DISPLAY too?
> 
>   Use case: If, like me, you're running a wayland compositor without Xwayland
> support then $DISPLAY won't be set.

Does the following work for you?

[btw, please reply-to-all, since subscription is optional and it avoids
 nongnu.org being a SPOF, thanks]
-------8<------
diff --git a/bin/dtas-console b/bin/dtas-console
index 0e762bd..7a7ed6c 100755
--- a/bin/dtas-console
+++ b/bin/dtas-console
@@ -26,7 +26,7 @@
 c = DTAS::UNIXClient.new
 cur = YAML.load(c.req('current'))
 readable = [ se, w, $stdin ]
-set_title = ENV['DISPLAY'] ? $stdout : nil
+set_title = (ENV['DISPLAY'] || ENV['WAYLAND_DISPLAY']) ? $stdout : nil
 
 # current rg mode
 rg_mode = DTAS::RGState::RG_MODE.keys.unshift("off")


  reply	other threads:[~2022-01-11 17:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07  5:35 [PATCH 0/4] a pile of misc improvements Eric Wong
2022-01-07  5:35 ` [PATCH 1/4] archive: support comments, default to none Eric Wong
2022-01-07  5:35 ` [PATCH 2/4] splitfx: use Etc.nprocessors for jobs if unspecified Eric Wong
2022-01-07  5:35 ` [PATCH 3/4] dtas-console: set X11 terminal title iff DISPLAY is set Eric Wong
2022-01-08 16:59   ` James Rowe
2022-01-11 17:29     ` Eric Wong [this message]
2022-01-11 18:14       ` James Rowe
2022-01-11 18:26         ` Eric Wong
2022-01-07  5:35 ` [PATCH 4/4] dtas-console: add 'i' toggle to show comments (metadata) Eric Wong
2022-01-07  9:34 ` [PATCH 5/4] splitfx: fix track_zpad with integer arg Eric Wong
2022-01-07  9:35 ` [PATCH 6/4] doc: drop ordered map from examples Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://80x24.org/dtas/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220111172959.GA20949@dcvr \
    --to=e@80x24.org \
    --cc=dtas-all@nongnu.org \
    --cc=jnrowe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/dtas.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).