From: Eric Wong <e@80x24.org>
To: dtas-all@nongnu.org
Subject: [PATCH 6/4] doc: drop ordered map from examples
Date: Fri, 7 Jan 2022 09:35:00 +0000 [thread overview]
Message-ID: <20220107093500.GB18116@dcvr> (raw)
In-Reply-To: <20220107053544.31240-1-e@80x24.org>
"omap" is specific to Ruby and makes interopability with other
languages more difficult.
While it's true environment variables are stored as an ordered
array of C strings (see environ(7)); order doesn't matter in
practice. Everyone in the real world treats the environment as
an unordered key-value store, and we shall follow.
---
Documentation/dtas-splitfx.pod | 4 ++--
examples/splitfx.sample.yml | 2 +-
examples/tfx.sample.yml | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/dtas-splitfx.pod b/Documentation/dtas-splitfx.pod
index f10c6a3..717cfa6 100644
--- a/Documentation/dtas-splitfx.pod
+++ b/Documentation/dtas-splitfx.pod
@@ -90,9 +90,9 @@ moves printing of output to stderr and disables parallel job invocation.
=item infile - string, the pathname of the original audio file
-=item env - ordered hash of environment variables to set for all commands
+=item env - hash of environment variables to set for all commands
- env: !omap
+ env:
FX: gain 3 stats
=item comments - hash of common tags for all audio (e.g. ARTIST, ALBUM, YEAR)
diff --git a/examples/splitfx.sample.yml b/examples/splitfx.sample.yml
index 9c29df2..979ba0d 100644
--- a/examples/splitfx.sample.yml
+++ b/examples/splitfx.sample.yml
@@ -11,7 +11,7 @@ comments:
# the sox command for dtas-player playback, there is no need to
# specify this as it is the default:
# command: exec sox "$INFILE" $SOXFMT - $TRIMFX $RGFX $FX
-env: !omap
+env:
PATH: $PATH
# these effects may be used in any command in this file, including targets
SOX_OPTS: $SOX_OPTS -R
diff --git a/examples/tfx.sample.yml b/examples/tfx.sample.yml
index b8add0b..144129f 100644
--- a/examples/tfx.sample.yml
+++ b/examples/tfx.sample.yml
@@ -4,7 +4,7 @@
# test_trimfx.rb relies on this.
---
infile: foo.flac
-env: !omap
+env:
PATH: $PATH
SOX_OPTS: $SOX_OPTS -R
I2: second.flac
prev parent reply other threads:[~2022-01-07 9:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 5:35 [PATCH 0/4] a pile of misc improvements Eric Wong
2022-01-07 5:35 ` [PATCH 1/4] archive: support comments, default to none Eric Wong
2022-01-07 5:35 ` [PATCH 2/4] splitfx: use Etc.nprocessors for jobs if unspecified Eric Wong
2022-01-07 5:35 ` [PATCH 3/4] dtas-console: set X11 terminal title iff DISPLAY is set Eric Wong
2022-01-08 16:59 ` James Rowe
2022-01-11 17:29 ` Eric Wong
2022-01-11 18:14 ` James Rowe
2022-01-11 18:26 ` Eric Wong
2022-01-07 5:35 ` [PATCH 4/4] dtas-console: add 'i' toggle to show comments (metadata) Eric Wong
2022-01-07 9:34 ` [PATCH 5/4] splitfx: fix track_zpad with integer arg Eric Wong
2022-01-07 9:35 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/dtas/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107093500.GB18116@dcvr \
--to=e@80x24.org \
--cc=dtas-all@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/dtas.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).