everything related to duct tape audio suite (dtas)
 help / color / mirror / code / Atom feed
From: Eric Wong <e@yhbt.net>
To: dtas-all@nongnu.org
Subject: [PATCH 1/2] splitfx: reduce syscalls for writing comments file
Date: Thu,  9 Apr 2020 20:12:21 +0000	[thread overview]
Message-ID: <20200409201222.24112-2-e@yhbt.net> (raw)
In-Reply-To: <20200409201222.24112-1-e@yhbt.net>

We can flush when all comments are buffered to avoid a writev(2)
syscall on every comment.
 lib/dtas/splitfx.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dtas/splitfx.rb b/lib/dtas/splitfx.rb
index 8ad919e..384df0f 100644
--- a/lib/dtas/splitfx.rb
+++ b/lib/dtas/splitfx.rb
@@ -207,11 +207,11 @@ def splitfx_spawn(target, t, opts)
       env["DITHERFX"] = "dither -s"
     comments = Tempfile.new(%W(dtas-splitfx-#{t.comments["TRACKNUMBER"]} .txt))
-    comments.sync = true
     t.comments.each do |k,v|
       env[k] = v.to_s
+    comments.flush
     env["COMMENTS"] = "--comment-file=#{comments.path}"
     infile_env(env, @infile)
     outarg = outfmt.to_sox_arg

  reply	other threads:[~2020-04-09 20:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09 20:12 [PATCH 0/2] some splitfx improvements Eric Wong
2020-04-09 20:12 ` Eric Wong [this message]
2020-04-09 20:12 ` [PATCH 2/2] splitfx: support --err-suffix option Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://80x24.org/dtas/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200409201222.24112-2-e@yhbt.net \
    --to=e@yhbt.net \
    --cc=dtas-all@nongnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).