From: Eric Wong <e@80x24.org>
To: dtas-all@nongnu.org
Subject: [PATCH] readahead: avoid Array#compact and Array#max on `false'
Date: Wed, 13 Nov 2019 03:00:37 +0000 [thread overview]
Message-ID: <20191113030037.653-1-e@80x24.org> (raw)
seek_to_cur_pos needs to return `nil', not `false' on
dead processes when monitoring processes for readahead.
---
bin/dtas-readahead | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bin/dtas-readahead b/bin/dtas-readahead
index 93ab8c9..99ba65c 100755
--- a/bin/dtas-readahead
+++ b/bin/dtas-readahead
@@ -57,7 +57,7 @@ def seek_to_cur_pos(cur_pid, fp)
end
end
rescue Errno::ENOENT => e # race, process is dead
- return false
+ return nil
rescue => e
warn "error reading FDs from for PID:#{cur_pid}: #{e.message}"
end
@@ -71,7 +71,7 @@ def seek_to_cur_pos(cur_pid, fp)
end
pos
rescue Errno::ENOENT => e # race, process is dead
- return false
+ return nil
end
def children_of(ppid)
reply other threads:[~2019-11-13 3:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/dtas/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113030037.653-1-e@80x24.org \
--to=e@80x24.org \
--cc=dtas-all@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/dtas.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).