From: Eric Wong <e@80x24.org>
To: <dtas-all@nongnu.org>
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] dtas-cueedit: escape path to temporary file
Date: Sat, 3 Oct 2015 09:38:36 +0000 [thread overview]
Message-ID: <20151003093836.13825-1-e@80x24.org> (raw)
Temporary files may still have spaces or weird chars in them.
Just keep in mind we need to use $EDITOR/$VISUAL as-is since that
may contain additional command-line arguments, so we cannot pass
an array.
---
bin/dtas-cueedit | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bin/dtas-cueedit b/bin/dtas-cueedit
index 603bf28..5e6970f 100755
--- a/bin/dtas-cueedit
+++ b/bin/dtas-cueedit
@@ -44,7 +44,7 @@ ARGV.each do |file|
backup.write(original) if backup
# user edits the file
- x!("#{editor} #{tmp.path}")
+ x!("#{editor} #{xs(tmp.path)}")
# avoid an expensive update if the user didn't change anything
current = File.binread(tmp.path)
--
EW
reply other threads:[~2015-10-03 9:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/dtas/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151003093836.13825-1-e@80x24.org \
--to=e@80x24.org \
--cc=dtas-all@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/dtas.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).