From: Eric Wong <e@80x24.org>
To: dtas-all@nongnu.org
Subject: [PATCH] restart "source ed" after env changes
Date: Wed, 24 Dec 2014 23:41:38 +0000 [thread overview]
Message-ID: <20141224234138.GA12207@dcvr.yhbt.net> (raw)
Merely converting the `before' source information to a hash is not
enough, as the `env' sub-hash is mosified in-place and shared with
the `after' hash. So use `inspect' to serialize and snapshot the
env and rely on a string comparison.
---
lib/dtas/player/client_handler.rb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/dtas/player/client_handler.rb b/lib/dtas/player/client_handler.rb
index c9ae2e4..37357f7 100644
--- a/lib/dtas/player/client_handler.rb
+++ b/lib/dtas/player/client_handler.rb
@@ -474,7 +474,7 @@ module DTAS::Player::ClientHandler # :nodoc:
when "cat"
io.emit(src.to_source_cat.to_yaml)
when "ed"
- before = src.to_state_hash
+ before = src.to_state_hash.inspect
sd = src.source_defaults
msg.each do |kv|
k, v = kv.split(/=/, 2)
@@ -492,7 +492,7 @@ module DTAS::Player::ClientHandler # :nodoc:
source_map_reload
end
end
- after = src.to_state_hash
+ after = src.to_state_hash.inspect
__current_requeue if before != after && @current.class == src.class
io.emit("OK")
else
--
EW
reply other threads:[~2014-12-24 23:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/dtas/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141224234138.GA12207@dcvr.yhbt.net \
--to=e@80x24.org \
--cc=dtas-all@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/dtas.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).