everything related to duct tape audio suite (dtas)
 help / color / mirror / code / Atom feed
* [PATCH] process: update comment for bug workaround
@ 2014-12-08  6:53 Eric Wong
  2014-12-08  6:59 ` [PATCH 2/1] process: update comment for bug workaround #2 Eric Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2014-12-08  6:53 UTC (permalink / raw)
  To: dtas-all; +Cc: Eric Wong

We're certain this is a workaround for a bug.  We may remove the
workaround at some point in the future; but not until the rest of
the world has had a chance to upgrade, too.
---
 lib/dtas/process.rb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/dtas/process.rb b/lib/dtas/process.rb
index d70e6e5..020737d 100644
--- a/lib/dtas/process.rb
+++ b/lib/dtas/process.rb
@@ -49,7 +49,8 @@ module DTAS::Process # :nodoc:
 
     pid = begin
       Process.spawn(env, cmd, opts)
-    rescue Errno::EINTR # Ruby bug?
+    rescue Errno::EINTR
+      # workaround for older Rubies https://bugs.ruby-lang.org/issues/8770
       retry
     end
     warn [ :spawn, pid, cmd ].inspect if $DEBUG
-- 
EW


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 2/1] process: update comment for bug workaround #2
  2014-12-08  6:53 [PATCH] process: update comment for bug workaround Eric Wong
@ 2014-12-08  6:59 ` Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2014-12-08  6:59 UTC (permalink / raw)
  To: dtas-all

Followup to commit 698e1f04580839ea29647f285b39b88fcbb46071
"process: update comment for bug workaround"
---
 lib/dtas/process.rb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/dtas/process.rb b/lib/dtas/process.rb
index 020737d..c0ce9a3 100644
--- a/lib/dtas/process.rb
+++ b/lib/dtas/process.rb
@@ -78,7 +78,8 @@ module DTAS::Process # :nodoc:
     env = env_expand(env, opts)
     pid = begin
       Process.spawn(env, *cmd, opts)
-    rescue Errno::EINTR # Ruby bug?
+    rescue Errno::EINTR
+      # workaround for older Rubies https://bugs.ruby-lang.org/issues/8770
       retry
     end
     w.close
-- 
EW

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-22  1:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-08  6:53 [PATCH] process: update comment for bug workaround Eric Wong
2014-12-08  6:59 ` [PATCH 2/1] process: update comment for bug workaround #2 Eric Wong

Code repositories for project(s) associated with this inbox:

	../../../dtas.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).