everything related to duct tape audio suite (dtas)
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: <dtas-all@nongnu.org>
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] splitfx: remove support for encoding opus
Date: Mon, 18 May 2015 07:51:01 +0000
Message-ID: <1431935461-13338-1-git-send-email-e@80x24.org> (raw)

Lossy file encoding has too many tunable variables and it is not a
good fit for an audio production tool such as dtas-splitfx.  This
was becoming a maintenance burden for me and is a sign of
featuritis.
---
 lib/dtas/splitfx.rb  | 15 ---------------
 test/test_splitfx.rb | 29 -----------------------------
 2 files changed, 44 deletions(-)

diff --git a/lib/dtas/splitfx.rb b/lib/dtas/splitfx.rb
index 9420faf..6bac27f 100644
--- a/lib/dtas/splitfx.rb
+++ b/lib/dtas/splitfx.rb
@@ -77,21 +77,6 @@ class DTAS::SplitFX # :nodoc:
           "channels" => 2,
         },
       },
-      "opusenc" => {
-        "command" => 'sox "$INFILE" $COMMENTS $OUTFMT - ' \
-           '$TRIMFX $FX $RATEFX $DITHERFX | opusenc --music ' \
-           '--raw-bits $BITS_PER_SAMPLE ' \
-           '$OPUSENC_BITRATE --raw-rate $RATE --raw-chan $CHANNELS ' \
-           '--raw-endianness $ENDIAN_OPUSENC ' \
-           '$OPUSENC_COMMENTS ' \
-           '- $OUTDIR$TRACKNUMBER.opus',
-        "format" => {
-          "bits" => 16,
-          "rate" => 48000,
-          "type" => "s16",
-          "channels" => 2,
-        },
-      },
     }
     @tracks = []
     @infmt = nil # wait until input is assigned
diff --git a/test/test_splitfx.rb b/test/test_splitfx.rb
index adb3508..49df49d 100644
--- a/test/test_splitfx.rb
+++ b/test/test_splitfx.rb
@@ -70,35 +70,6 @@ class TestSplitfx < Testcase
 
         cmp = "cmp result.s32 expect.s32"
         assert system(cmp), cmp
-
-        # try Ogg Opus, use opusenc/opusdec for now since that's available
-        # in Debian 7.0 (sox.git currently has opusfile support, but that
-        # hasn't made it into Debian, yet)
-        if `which opusenc 2>/dev/null`.size > 0 &&
-           `which opusdec 2>/dev/null`.size > 0
-          WAIT_ALL_MTX.synchronize do
-            tmp_err('opus.err.txt') { sfx.run("opusenc", opts) }
-          end
-          assert_contains_stats('opus.err.txt')
-
-          # ensure opus lengths match flac ones, we decode using opusdec
-          # since sox does not yet have opus support in Debian 7.0
-          %w(1 2).each do |nr|
-            cmd = "opusdec #{nr}.opus #{nr}.wav 2>/dev/null"
-            assert system(cmd), cmd
-            assert_equal `soxi -D #{nr}.flac`, `soxi -D #{nr}.wav`
-          end
-
-          # ensure 16/44.1kHz FLAC works (CDDA-like)
-          File.unlink('1.flac', '2.flac')
-          WAIT_ALL_MTX.synchronize do
-            tmp_err('flac-cdda.err.txt') { sfx.run("flac-cdda", opts) }
-          end
-          assert_contains_stats('flac-cdda.err.txt')
-          %w(1 2).each do |nr|
-            assert_equal `soxi -D #{nr}.flac`, `soxi -D #{nr}.wav`
-          end
-        end
       end
     end
   end
-- 
EW



                 reply	other threads:[~2015-05-18  7:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://80x24.org/dtas/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431935461-13338-1-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=dtas-all@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

everything related to duct tape audio suite (dtas)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://80x24.org/dtas-all
	git clone --mirror http://ou63pmih66umazou.onion/dtas-all

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 dtas-all dtas-all/ https://80x24.org/dtas-all \
		dtas-all@nongnu.org
	public-inbox-index dtas-all

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.audio.dtas
	nntp://ou63pmih66umazou.onion/inbox.comp.audio.dtas
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for the project(s) associated with this inbox:

	dtas.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git