From: Eric Wong <e@80x24.org>
To: <dtas-all@nongnu.org>
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] splitfx: fix non-generic, user-specified targets
Date: Sun, 17 May 2015 01:37:23 +0000 [thread overview]
Message-ID: <1431826643-29448-1-git-send-email-e@80x24.org> (raw)
Regression appeared in the previous commit, oops.
commit ab63c7bb1b69423f8c39a60dd00230c560eecfc4
(splitfx: fix lossy output with player command is in use)
---
lib/dtas/splitfx.rb | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/lib/dtas/splitfx.rb b/lib/dtas/splitfx.rb
index 1de9229..e4997cc 100644
--- a/lib/dtas/splitfx.rb
+++ b/lib/dtas/splitfx.rb
@@ -165,7 +165,13 @@ class DTAS::SplitFX # :nodoc:
end
def splitfx_spawn(target, t, opts)
- target = @targets[target] || generic_target(target)
+ generic = false
+ if tgt = @targets[target]
+ target = tgt
+ else
+ generic = true
+ target = generic_target(target)
+ end
outfmt = target["format"]
# default format:
@@ -178,7 +184,9 @@ class DTAS::SplitFX # :nodoc:
# as a self-describing format to the actual encoding instances
player_cmd = @command
suffix = outfmt.type
- outfmt.type = 'sox' if player_cmd
+ if player_cmd && generic
+ outfmt.type = 'sox'
+ end
env = outfmt.to_env
# set very high quality resampling if using 24-bit or higher output
--
EW
reply other threads:[~2015-05-17 1:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/dtas/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431826643-29448-1-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=dtas-all@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/dtas.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).