everything related to duct tape audio suite (dtas)
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: <dtas-all@nongnu.org>
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] splitfx: fix lossy output with player command is in use
Date: Sun, 10 May 2015 23:03:10 +0000	[thread overview]
Message-ID: <1431298990-8733-1-git-send-email-e@80x24.org> (raw)

We must ensure lossy encodings do not get lossily-encoded twice,
only once at the final stage.  There is no effect for lossless
outputs as lossless is the common case for splitfx users.
 lib/dtas/splitfx.rb | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/lib/dtas/splitfx.rb b/lib/dtas/splitfx.rb
index a14d221..1de9229 100644
--- a/lib/dtas/splitfx.rb
+++ b/lib/dtas/splitfx.rb
@@ -173,6 +173,12 @@ class DTAS::SplitFX # :nodoc:
       outfmt = @infmt.dup
       outfmt.type = "flac"
+    # player commands will use SOXFMT by default, so we must output that
+    # as a self-describing format to the actual encoding instances
+    player_cmd = @command
+    suffix = outfmt.type
+    outfmt.type = 'sox' if player_cmd
     env = outfmt.to_env
     # set very high quality resampling if using 24-bit or higher output
@@ -204,7 +210,7 @@ class DTAS::SplitFX # :nodoc:
     outarg = outfmt.to_sox_arg
     outarg << "-C#@compression" if @compression
     env["OUTFMT"] = xs(outarg)
-    env["SUFFIX"] = outfmt.type
+    env["SUFFIX"] = suffix
     env["OUTDIR"] = @outdir ? "#@outdir/".squeeze('/') : ''
@@ -215,7 +221,7 @@ class DTAS::SplitFX # :nodoc:
     # already takes those into account.  In other words, use our
     # target-specific commands like a dtas-player sink:
     #   @command | (INFILE= FX= TRIMFX=; target['command'])
-    if player_cmd = @command
+    if player_cmd
       sub_env = { 'INFILE' => '-', 'FX' => '', 'TRIMFX' => '' }
       sub_env_s = sub_env.inject("") { |s,(k,v)| s << "#{k}=#{v} " }
       command = "#{player_cmd} | (#{sub_env_s}; #{command})"

                 reply	other threads:[~2015-05-10 23:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://80x24.org/dtas/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431298990-8733-1-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=dtas-all@nongnu.org \
    --subject='Re: [PATCH] splitfx: fix lossy output with player command is in use' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

everything related to duct tape audio suite (dtas)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://80x24.org/dtas-all
	git clone --mirror http://ou63pmih66umazou.onion/dtas-all

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 dtas-all dtas-all/ https://80x24.org/dtas-all \
	public-inbox-index dtas-all

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:


AGPL code for this site: git clone http://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/public-inbox.git