From: Eric Wong <e@80x24.org>
To: <dtas-all@nongnu.org>
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] reduce syscalls in recvmsg invocations
Date: Mon, 22 Dec 2014 01:12:41 +0000 [thread overview]
Message-ID: <1419210761-26539-1-git-send-email-e@80x24.org> (raw)
Favor IO.select over IO#wait since the latter makes another
ioctl syscall (which we'll make anyways for IO#nread).
Having BasicSocket#recvmsg and recvmsg_nonblock detect the buffer
size requires extra syscalls, so pass explict maxmesglen, flags, and
maxcontrollen args to elide auto-detection since we already have the
buffered amount from IO#nread.
This cuts more syscalls from the "dtas-tl cat" invocation with
larger tracklists.
---
lib/dtas/unix_accepted.rb | 2 +-
lib/dtas/unix_client.rb | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/dtas/unix_accepted.rb b/lib/dtas/unix_accepted.rb
index 2c82d2a..3008afc 100644
--- a/lib/dtas/unix_accepted.rb
+++ b/lib/dtas/unix_accepted.rb
@@ -56,7 +56,7 @@ class DTAS::UNIXAccepted # :nodoc:
begin
begin
- msg, _, _ = io.recvmsg_nonblock(nread)
+ msg, _, _ = io.recvmsg_nonblock(nread, 0, 0)
rescue Errno::EAGAIN
return :wait_readable
rescue EOFError, SystemCallError
diff --git a/lib/dtas/unix_client.rb b/lib/dtas/unix_client.rb
index 40dedcc..7382ea6 100644
--- a/lib/dtas/unix_client.rb
+++ b/lib/dtas/unix_client.rb
@@ -38,9 +38,9 @@ class DTAS::UNIXClient # :nodoc:
end
def res_wait(timeout = nil)
- @to_io.wait(timeout)
+ IO.select([@to_io], nil, nil, timeout)
nr = @to_io.nread
nr > 0 or raise EOFError, "unexpected EOF from server"
- @to_io.recvmsg[0]
+ @to_io.recvmsg(nr, 0, 0)[0]
end
end
--
EW
reply other threads:[~2014-12-22 1:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/dtas/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419210761-26539-1-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=dtas-all@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/dtas.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).