about summary refs log tree commit
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2019-01-01 08:57:24 +0000
committerEric Wong <e@80x24.org>2021-03-19 20:16:17 +0000
commitac729eafcde481192a9032aff3d7f49b382c3ab6 (patch)
tree65833906ce79f49e5b87679c971e39b3ebca5fa0
parent94cf57d94d841f535066bb279b46930bf134674b (diff)
downloadcgit-ac729eafcde481192a9032aff3d7f49b382c3ab6.tar.gz
ui-log: improve decoration display for browsers without CSS
Text-based browsers without CSS support show all the decorations
bunched together without spacing.  Rely on a whitespace instead
of CSS support.

Signed-off-by: Eric Wong <e@80x24.org>
-rw-r--r--cgit.css1
-rw-r--r--ui-log.c5
2 files changed, 5 insertions, 1 deletions
diff --git a/cgit.css b/cgit.css
index f9549a1..6ab28a1 100644
--- a/cgit.css
+++ b/cgit.css
@@ -708,7 +708,6 @@ div#cgit div.commit-subject a.tag-deco,
 div#cgit div.commit-subject a.tag-annotated-deco,
 div#cgit div.commit-subject a.remote-deco,
 div#cgit div.commit-subject a.deco {
-        margin-left: 1em;
         font-size: 75%;
 }
 
diff --git a/ui-log.c b/ui-log.c
index 6914f75..3679c0a 100644
--- a/ui-log.c
+++ b/ui-log.c
@@ -67,6 +67,7 @@ void show_commit_decorations(struct commit *commit)
         while (deco) {
                 struct object_id peeled;
                 int is_annotated = 0;
+
                 strlcpy(buf, prettify_refname(deco->name), sizeof(buf));
                 switch(deco->type) {
                 case DECORATION_NONE:
@@ -74,11 +75,13 @@ void show_commit_decorations(struct commit *commit)
                          * don't display anything. */
                         break;
                 case DECORATION_REF_LOCAL:
+                        html(" ");
                         cgit_log_link(buf, NULL, "branch-deco", buf, NULL,
                                 ctx.qry.vpath, 0, NULL, NULL,
                                 ctx.qry.showmsg, 0);
                         break;
                 case DECORATION_REF_TAG:
+                        html(" ");
                         if (!peel_ref(deco->name, &peeled))
                                 is_annotated = !oidcmp(&commit->object.oid, &peeled);
                         cgit_tag_link(buf, NULL, is_annotated ? "tag-annotated-deco" : "tag-deco", buf);
@@ -86,12 +89,14 @@ void show_commit_decorations(struct commit *commit)
                 case DECORATION_REF_REMOTE:
                         if (!ctx.repo->enable_remote_branches)
                                 break;
+                        html(" ");
                         cgit_log_link(buf, NULL, "remote-deco", NULL,
                                 oid_to_hex(&commit->object.oid),
                                 ctx.qry.vpath, 0, NULL, NULL,
                                 ctx.qry.showmsg, 0);
                         break;
                 default:
+                        html(" ");
                         cgit_commit_link(buf, NULL, "deco", ctx.qry.head,
                                         oid_to_hex(&commit->object.oid),
                                         ctx.qry.vpath);