From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id AA23D1F487 for ; Fri, 15 Dec 2023 00:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1702598891; bh=QEcEDA64zqEBnZDJHUoMMzDiOAPUVl85fPVwPdgwmiY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Ojkv83T9NL5JE9zCGn+3sWOf0drmYF1u+SkuDL1Is4HVDSMaHa5T88qpsYuZKgfXO Jmqo3md37I0AAwOjx0Q/+HL5DAfGBWK3W0CZZOFFhuEQFyHSSRYdRFCpucG2a5RfXU N9fwO8LZAVON5c0nK1NYbKZlp8rxMqgzvakJYzWw= From: Eric Wong To: spew@80x24.org Subject: [PATCH 4/5] git: quiet down `rev-parse --git-path' errors Date: Thu, 14 Dec 2023 19:08:09 -0500 Message-Id: <20231215000810.3458531-4-e@80x24.org> In-Reply-To: <20231215000810.3458531-1-e@80x24.org> References: <20231215000810.3458531-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: This fixes t/mda.t with git 1.8.5 --- lib/PublicInbox/Git.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm index 9c4d938e..6c4fcf93 100644 --- a/lib/PublicInbox/Git.pm +++ b/lib/PublicInbox/Git.pm @@ -107,7 +107,9 @@ sub git_path ($$) { $d; } else { local $/ = "\n"; - my $s = $self->qx(qw(rev-parse --git-path), $path); + my $rdr = { 2 => \my $err }; + my $s = $self->qx([qw(rev-parse --git-path), $path], + undef, $rdr); chomp $s; # git prior to 2.5.0 did not understand --git-path