From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 5A2491F724 for ; Fri, 27 Oct 2023 09:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1698399641; bh=omPUfJcrutffGwuSNjwETwu/PG7ZQWhrzbepAazkKkQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=m+LZz4lFw8Np9ckSGTLnErEZDIOwgCCAbEj7bF+FtlCjznoi+OJwRDruEN0IWPtTC ql8pObSebB2jChylawe39OUVv4HU8em7GMrkzFqibTFUUZwjMr2cBzutyyxFGd4aKm G6onOh9I1mHh/eu0b9+IJIhc5J806ZxMOjYadRSs= From: Eric Wong To: spew@80x24.org Subject: [PATCH 09/18] git_credential: use IO::Handle->close Date: Fri, 27 Oct 2023 09:40:30 +0000 Message-ID: <20231027094039.3788289-9-e@80x24.org> In-Reply-To: <20231027094039.3788289-1-e@80x24.org> References: <20231027094039.3788289-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: --- lib/PublicInbox/GitCredential.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/GitCredential.pm b/lib/PublicInbox/GitCredential.pm index 10114a10..a4444e2c 100644 --- a/lib/PublicInbox/GitCredential.pm +++ b/lib/PublicInbox/GitCredential.pm @@ -30,7 +30,7 @@ sub run ($$;$) { close $in_w or die "close (git credential $op): $!"; return $out_r if $op eq 'fill'; <$out_r> and die "unexpected output from `git credential $op'\n"; - close $out_r or die "`git credential $op' failed: \$!=$! \$?=$?\n"; + $out_r->close or die "`git credential $op' failed: \$!=$! \$?=$?\n"; } sub check_netrc { @@ -61,7 +61,7 @@ sub fill { /\A([^=]+)=(.*)\z/ or die "bad line: $_\n"; $self->{$1} = $2; } - close $out_r or die "git credential fill failed: \$!=$! \$?=$?\n"; + $out_r->close or die "git credential fill failed: \$!=$! \$?=$?\n"; $self->{filled} = 1; }