From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id BA8301F87D for ; Fri, 27 Oct 2023 09:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1698399641; bh=p5H7iE/uQS6jqlPiiFDIksPDpy6h9w6wz99fNRkCj54=; h=From:To:Subject:Date:In-Reply-To:References:From; b=hFPaEINEOCxJqF/eHfccF/Mp8P5QQlPAfYpIWvzjIZKtCLT5OVIwDl25SESm9gqXr RZ7r90crwGXegf6TvxPnjVerzEUKfALlbacgluHuhs8vKpsMX4ZKpjMmFNo7waL252 reCn7CdOElZml4yW1X+ROWH3G/3Wq+J0K5M39rPU= From: Eric Wong To: spew@80x24.org Subject: [PATCH 12/18] config: use ->close for popen_rd pipe Date: Fri, 27 Oct 2023 09:40:33 +0000 Message-ID: <20231027094039.3788289-12-e@80x24.org> In-Reply-To: <20231027094039.3788289-1-e@80x24.org> References: <20231027094039.3788289-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: --- lib/PublicInbox/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm index d156b2d3..e2e87cad 100644 --- a/lib/PublicInbox/Config.pm +++ b/lib/PublicInbox/Config.pm @@ -192,7 +192,7 @@ sub git_config_dump { push(@cmd, '-f', $file) if !@opt_c && defined($file); my $fh = popen_rd(\@cmd, \%env, $opt); my $rv = config_fh_parse($fh, "\0", "\n"); - close $fh or die "@cmd failed: \$?=$?\n"; + $fh->close or die "@cmd failed: \$?=$?\n"; $rv->{-opt_c} = \@opt_c if @opt_c; # for ->urlmatch $rv->{-f} = $file; bless $rv, $class;