From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 851B61F87D for ; Thu, 19 Oct 2023 12:40:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1697719221; bh=gb+yUU9PfIM+EWP9f+6aR4PIl4atc0I9IHBXulfsVHo=; h=From:To:Subject:Date:In-Reply-To:References:From; b=TY2sg6beoS/I88RNtVs5WlmRqdox+NMukYOtotAfRXhR4+QZznbD3M4B0VLELWGPL 2VJbS8RI5Hx8TyMglm8yOZuFaJvxh/AV9ASkNWyl+Lh2KJ5DV5QAaWtPlwpp0yRan1 K51xBVYBwPZvid8kqLIqCLRxPRMQj/VWTghaUkWQ= From: Eric Wong To: spew@80x24.org Subject: [PATCH 16/18] githttpbackend: fix outdated comments Date: Thu, 19 Oct 2023 12:40:16 +0000 Message-ID: <20231019124018.2109632-16-e@80x24.org> In-Reply-To: <20231019124018.2109632-1-e@80x24.org> References: <20231019124018.2109632-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: --- lib/PublicInbox/GitHTTPBackend.pm | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm index d7e0bced..7228555b 100644 --- a/lib/PublicInbox/GitHTTPBackend.pm +++ b/lib/PublicInbox/GitHTTPBackend.pm @@ -145,16 +145,12 @@ sub parse_cgi_headers { # {parse_hdr} for Qspawn } } - # fallback to WwwCoderepo if cgit 404s. Duplicating $ctx prevents - # ->finalize from the current Qspawn from using qspawn.wcb. - # This makes qspawn skip ->async_pass and causes - # PublicInbox::HTTPD::Async::event_step to close shortly after + # fallback to WwwCoderepo if cgit 404s if ($code == 404 && $ctx->{www} && !$ctx->{_coderepo_tried}++) { my $wcb = delete $ctx->{env}->{'qspawn.wcb'}; $ctx->{env}->{'plack.skip-deflater'} = 1; # prevent 2x gzip $ctx->{env}->{'qspawn.fallback'} = $code; my $res = $ctx->{www}->coderepo->srv($ctx); - # for ->psgi_return_init_cb $ctx->{env}->{'qspawn.wcb'} = $wcb; $res; # CODE or ARRAY ref } else {