From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH 06/16] process_pipe: do not run `close' perlop unless requested
Date: Sun, 1 Oct 2023 02:43:13 +0000 [thread overview]
Message-ID: <20231001024323.1960491-6-e@80x24.org> (raw)
In-Reply-To: <20231001024323.1960491-1-e@80x24.org>
If a user is relying on reference counts to invalidate FDs
(as we do in many places), rely on them instead of explicit
`close'. This forces us to do a better job of managing refs
and avoiding redundant fields which make our code more fragile.
---
lib/PublicInbox/ProcessPipe.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/ProcessPipe.pm b/lib/PublicInbox/ProcessPipe.pm
index 16971801..ba2c1ecb 100644
--- a/lib/PublicInbox/ProcessPipe.pm
+++ b/lib/PublicInbox/ProcessPipe.pm
@@ -58,7 +58,7 @@ sub FILENO { fileno($_[0]->{fh}) }
sub _close ($;$) {
my ($self, $wait) = @_;
my ($fh, $pid) = delete(@$self{qw(fh pid)});
- my $ret = defined($fh) ? close($fh) : '';
+ my $ret = (defined($fh) && $wait) ? close($fh) : ($fh = '');
return $ret unless defined($pid) && $self->{ppid} == $$;
if ($wait) { # caller cares about the exit status:
# synchronous wait via defined(wantarray) on awaitpid:
next prev parent reply other threads:[~2023-10-01 2:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 2:43 [PATCH 01/16] git: decouple cat_async_retry from POSIX pipe semantics Eric Wong
2023-10-01 2:43 ` [PATCH 02/16] git: use Unix stream sockets for `cat-file --batch-*' Eric Wong
2023-10-01 2:43 ` [PATCH 03/16] git+gcf2client: switch to level-triggered wakeups Eric Wong
2023-10-01 2:43 ` [PATCH 04/16] gcf2: Eric Wong
2023-10-01 2:43 ` [PATCH 05/16] t/git: show git_version in diag output Eric Wong
2023-10-01 2:43 ` Eric Wong [this message]
2023-10-01 2:43 ` [PATCH 07/16] git: improve error reporting Eric Wong
2023-10-01 2:43 ` [PATCH 08/16] git: packed_bytes: account for TOUTTOC between glob and stat Eric Wong
2023-10-01 2:43 ` [PATCH 09/16] gcf2client: warnings Eric Wong
2023-10-01 2:43 ` [PATCH 10/16] lei rediff: order-file support Eric Wong
2023-10-01 2:43 ` [PATCH 11/16] lei: correct exit signal Eric Wong
2023-10-01 2:43 ` [PATCH 12/16] lei mail-diff: remove correct temporary directory Eric Wong
2023-10-01 2:43 ` [PATCH 13/16] lei rediff: perl -e instead of -E Eric Wong
2023-10-01 2:43 ` [PATCH 14/16] lei_store: unlink early Eric Wong
2023-10-01 2:43 ` [PATCH 15/16] overidx: fix version comparison Eric Wong
2023-10-01 2:43 ` [PATCH 16/16] enable warnings globally Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231001024323.1960491-6-e@80x24.org \
--to=e@80x24.org \
--cc=spew@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).