[PATCH] spawn: rely on auto-vivification for options

[Eric Wong <e@80x24.org>]

While we're at it, we can also avoid the fileno call
since spawn() can take IO/GLOB references nowadays.
---
 lib/PublicInbox/Spawn.pm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm
index 38619fc2..c18c2388 100644
--- a/lib/PublicInbox/Spawn.pm
+++ b/lib/PublicInbox/Spawn.pm
@@ -332,7 +332,6 @@ sub spawn ($;$$) {
 	my ($cmd, $env, $opts) = @_;
 	my $f = which($cmd->[0]) // die "$cmd->[0]: command not found\n";
 	my @env;
-	$opts ||= {};
 	my %env = (%ENV, $env ? %$env : ());
 	while (my ($k, $v) = each %env) {
 		push @env, "$k=$v" if defined($v);
@@ -367,8 +366,7 @@ sub spawn ($;$$) {
 sub popen_rd {
 	my ($cmd, $env, $opt) = @_;
 	pipe(my ($r, $w)) or die "pipe: $!\n";
-	$opt ||= {};
-	$opt->{1} = fileno($w);
+	local $opt->{1} = $w;
 	my $pid = spawn($cmd, $env, $opt);
 	return ($r, $pid) if wantarray;
 	my $s = gensym;